You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yq -ie reformats the readme-vars.yml and makes the following changes:
Removes all empty lines between yaml keys
Removes all empty space betwen braces {} and values (ie. - { cap_add_var: "NET_ADMIN" } becomes - {cap_add_var: "NET_ADMIN"} throughout the readme-vars.yml)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip custom readme and images containing
init_diagram: falseBlurb being added to Jenkinsfile was tested locally for the following scenarios:
init_diagram: addedinit_diagram: falsein readme-vars.yml: not addedThe editing of readme-vars.yml, commit and push to github will have to be tested live after merge unfortunately.I'm not 100% sure the double escapes
\\in Jenkinsfile are necessary here (I believe they are, but we'll find out after merge for sure).Bash script also tested by manually modifying a synclounge dev branch's Jenkinsfile to manually add an active stage for updating readme-vars.yml.
Git changes to Jenkinsfile here: linuxserver/docker-synclounge@linuxserver:b16e431...linuxserver:48a66f2#diff-e6ffa5dc854b843b3ee3c3c28f8eae2f436c2df2b1ca299cca1fa5982e390cf8
First jenkins build: https://ci.linuxserver.io/blue/organizations/jenkins/Docker-Pipeline-Builders%2Fdocker-synclounge/detail/readme-test/10/pipeline/108
Bot commit with readme-vars.yml update: linuxserver/docker-synclounge@48a66f2
Second build: https://ci.linuxserver.io/blue/organizations/jenkins/Docker-Pipeline-Builders%2Fdocker-synclounge/detail/readme-test/11/pipeline/108
Downsides:
yq -iereformats the readme-vars.yml and makes the following changes:{}and values (ie.- { cap_add_var: "NET_ADMIN" }becomes- {cap_add_var: "NET_ADMIN"}throughout the readme-vars.yml)Needs linuxserver/docker-d2-builder#2 merged