-
-
Notifications
You must be signed in to change notification settings - Fork 314
Update README #900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README #900
Conversation
|
PR build pushed to |
|
The mod can set the env automatically without requiring the user to add it. |
|
The mod has two possible options for the variable though. Would we default to one with the option of using the other? |
|
Oh I hadn't noticed that. Ignore me then |
|
As discussed in #899 we can probably strip this to the one version, and then have the mod set the variable with a check to see if the user has specified one manually. This would maintain backwards compatibility as no additional user setting need to be made to enable to mod to function for existing installs. |
|
So we don't need to set the variable if intending to use normal rffmpeg? Only for wol_rffmpeg. I can update the PR if so |
|
I was planning to just auto set it to wol rffmpeg if nothing is set by the user var, and document them both as optional in the readme. Need to add the port etc to readme also from previous pulls. I'm away currently but hoping to get time tonight to quickly add a one line if to set the var to wol if not set by user and update readme. The wol rffmpeg version is just a sys link to the wol bash script which acts as a wrapper to rffmpeg. If running without wol only addition is a single ping to host and a log entry if the host is down. Having var auto set as a backup will ensure the mod works as previous for anyone who set ffmpeg manually and isn't keeping up with the release notes. |
|
superseded by #901 |
ffmpeg path is no longer updatable. Edited the mod README to reflect the requirement to set env
FFMPEG_PATHto override the run flag.