-
-
Notifications
You must be signed in to change notification settings - Fork 298
Set FFMPEG_PATH for Jellyfin 10.8.13+ support. Update Readme #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aptalca
merged 1 commit into
linuxserver:jellyfin-rffmpeg
from
junkman690:jellyfin-rffmpeg
May 19, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I'm wrong on this, but I think WOL should still work outside of host network mode when targeting the NAT'd WAN IP (see my NAT WoL instructions in this file), so long as the subnet is available to the container?
I don't have this configured currently, nor am I aware of how you would expose the subnet so I'd have to test it to be sure. Maybe it could be run in bridged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick search shows it might be possible but require additional setup depending if its a unicast, subnet broadcast or IP broadcast, however I am not sure how Docker's networking stack would handle these, nor do I have that setup in place to test with. I vaguely recall trying a few different methods before settling on using the WoL container as it meant there was no need to change router or switch settings to enable wake while still allowing Jellyfin to be NAT'd.