update pr template #5340
Merged
update pr template #5340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philli-m
reviewed
Nov 30, 2023
goapunk
reviewed
Nov 30, 2023
hom3mad3
force-pushed
the
mr-2023-11-update-pr-template
branch
from
5543b31 to
38c9e2a
Compare
|
@mara @goapunk @philli-m updated pr template to have at least a human-friendly description and added the testing instructions to checklist. keeping in mind this is just a template and should be adapted to specific needs and context. what do you think? here is what my ideal PR looks like. I will probably use this format for frontend stuff as it lends itself well, specially with the screenshots. |
philli-m
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Updating our PR template for clearer communication and easier review.
At the moment, it's challenging to understand the goal of a PR and how to test it without having to ask the author. The suggested changes aim to improve the workflow for PR reviewers.
Tasks