Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7274] ckeditor5 image alt text validation #5426

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Jan 30, 2024

Describe your changes
Add the new image validator from a4 to all ckeditor5 fields which can have images. It should no longer be possible to add images and save the form without setting an alt text. Affected fields are (document paragraphs, maptopics, newsletter, platform email, plans, topics)

depends on liqd/adhocracy4#1520

Tasks

  • PR name contains story or task reference
  • Steps to recreate and test the changes
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@goapunk goapunk changed the title Jd 2024 01 image alt text validation [7274] ckeditor5 image alt text validation Jan 30, 2024
@goapunk goapunk force-pushed the jd-2024-01-image-alt-text-validation branch 2 times, most recently from 7bb3bf5 to 66bada7 Compare January 30, 2024 09:29
@goapunk goapunk added Dev: A4 depending PR or issue dependent on A4 migration-breaks-db PR contains migrations which can't be reverted labels Jan 30, 2024
@goapunk goapunk requested review from m4ra, philli-m and hom3mad3 January 30, 2024 09:32
Copy link
Contributor

@m4ra m4ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally all help_text shall move to forms, so we don't get new migrations every time we want to edit text. Here I pointed to only those related to ckeditor, as it is now the focus, and we may be asked to change it again soon.

@goapunk goapunk changed the title [7274] ckeditor5 image alt text validation WIP: [7274] ckeditor5 image alt text validation Jan 30, 2024
@goapunk
Copy link
Contributor Author

goapunk commented Jan 30, 2024

Ideally all help_text shall move to forms, so we don't get new migrations every time we want to edit text. Here I pointed to only those related to ckeditor, as it is now the focus, and we may be asked to change it again soon.

the help texts are done in #5412 once that is merged I will recreate the migrations here so they don't include the helptext anymore

@goapunk goapunk force-pushed the jd-2024-01-image-alt-text-validation branch from 9b55dfc to 78b9bc4 Compare January 30, 2024 14:01
@goapunk goapunk force-pushed the jd-2024-01-image-alt-text-validation branch from 78b9bc4 to 63528f8 Compare January 30, 2024 14:15
@goapunk goapunk changed the title WIP: [7274] ckeditor5 image alt text validation [7274] ckeditor5 image alt text validation Jan 30, 2024
@goapunk goapunk requested a review from m4ra January 30, 2024 14:16
Copy link
Contributor

@m4ra m4ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
So now this PR needs to wait for the A4 squashing migrations?

@goapunk
Copy link
Contributor Author

goapunk commented Jan 30, 2024

Looks good. So now this PR needs to wait for the A4 squashing migrations?

If you mean the migrations from the two a4 PRs we talked about earlier, they are squashed already

@m4ra m4ra merged commit c16ca00 into main Feb 1, 2024
3 checks passed
@m4ra m4ra deleted the jd-2024-01-image-alt-text-validation branch February 1, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev: A4 depending PR or issue dependent on A4 migration-breaks-db PR contains migrations which can't be reverted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants