-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7274] ckeditor5 image alt text validation #5426
Conversation
7bb3bf5
to
66bada7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally all help_text shall move to forms, so we don't get new migrations every time we want to edit text. Here I pointed to only those related to ckeditor, as it is now the focus, and we may be asked to change it again soon.
meinberlin/apps/newsletters/migrations/0009_alter_newsletter_body.py
Outdated
Show resolved
Hide resolved
meinberlin/apps/offlineevents/migrations/0009_alter_offlineevent_description.py
Outdated
Show resolved
Hide resolved
meinberlin/apps/platformemails/migrations/0005_alter_platformemail_body.py
Outdated
Show resolved
Hide resolved
meinberlin/apps/maptopicprio/migrations/0013_alter_maptopic_description.py
Outdated
Show resolved
Hide resolved
meinberlin/apps/plans/migrations/0062_alter_plan_description.py
Outdated
Show resolved
Hide resolved
meinberlin/apps/topicprio/migrations/0014_alter_topic_description.py
Outdated
Show resolved
Hide resolved
the help texts are done in #5412 once that is merged I will recreate the migrations here so they don't include the helptext anymore |
9b55dfc
to
78b9bc4
Compare
all ckeditor5 fields fixes #5394
78b9bc4
to
63528f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
So now this PR needs to wait for the A4 squashing migrations?
If you mean the migrations from the two a4 PRs we talked about earlier, they are squashed already |
Describe your changes
Add the new image validator from a4 to all ckeditor5 fields which can have images. It should no longer be possible to add images and save the form without setting an alt text. Affected fields are (document paragraphs, maptopics, newsletter, platform email, plans, topics)
depends on liqd/adhocracy4#1520
Tasks