[#8751] Add kiezradar 5 limit exceeded alert

changelog/_8878.md

@@ -0,0 +1,3 @@
+## Added
+
+- Added kiezradar 5 limit exceeded alert

meinberlin/react/kiezradar/EditKiezradar.jsx

@@ -1,59 +1,31 @@
-import React, { useEffect, useState } from 'react'
+import React from 'react'
 import django from 'django'
 import { useParams } from 'react-router-dom'
 import Kiezradar from './Kiezradar'
-import Loading from './Loading'
 import { alert as Alert } from 'adhocracy4'
 
 const editText = django.gettext('Edit')
 const errorKiezText = django.gettext('Failed to fetch Kiez')
 const errorText = django.gettext('Error')
 
-export default function EditKiezradar (props) {
+export default function EditKiezradar ({ kiezradars, ...props }) {
   const { id } = useParams()
-  const [kiezradar, setKiezradar] = useState([])
-  const [loading, setLoading] = useState(false)
-  const [error, setError] = useState(null)
-
-  useEffect(() => {
-    const fetchKiezradar = async () => {
-      try {
-        setLoading(true)
-        setError(null)
-
-        const response = await fetch(props.apiUrl + id)
-
-        if (!response.ok) {
-          throw new Error(errorKiezText)
-        }
+  const kiezradar = kiezradars?.find(
+    (kiezradar) => kiezradar.id === parseInt(id, 10)
+  )
 
-        const data = await response.json()
-        setKiezradar(data)
-      } catch (err) {
-        setError(err.message)
-      } finally {
-        setLoading(false)
-      }
-    }
-    fetchKiezradar()
-  }, [])
+  if (!kiezradar) {
+    return (
+      <div className="kiezradar__error">
+        <Alert type="danger" message={errorText + ': ' + errorKiezText} />
+      </div>
+    )
+  }
 
   return (
-    <div aria-live="polite">
-      {loading
-        ? <Loading />
-        : error
-          ? (
-            <div className="kiezradar__error">
-              <Alert type="danger" message={errorText + ': ' + error} />
-            </div>
-            )
-          : (
-            <>
-              <h2>{editText + ' ' + kiezradar.name}</h2>
-              <Kiezradar {...props} kiezradar={kiezradar} />
-            </>
-            )}
-    </div>
+    <>
+      <h2>{editText + ' ' + kiezradar.name}</h2>
+      <Kiezradar {...props} kiezradar={kiezradar} />
+    </>
   )
 }

meinberlin/react/kiezradar/Kiezradar.jsx

@@ -11,9 +11,6 @@ const nameYourKiezText = django.gettext('Name your Kiez selection')
 const saveText = django.gettext('Save Kiez selection')
 const savingText = django.gettext('Saving')
 const errorText = django.gettext('Error')
-const errorLimitedExceededText = django.gettext(
-  'Users can only have up to 5 kiezradar filters. Delete a filter to create a new one.'
-)
 const errorUpdateKiezText = django.gettext('Failed to update kiezradar filter')
 
 const CENTRAL_BERLIN = [13.4050, 52.5200]
@@ -28,11 +25,17 @@ const defaultPoint = {
   }
 }
 
-export default function Kiezradar ({ kiezradar, onKiezradarSave, ...props }) {
+export default function Kiezradar ({
+  kiezradar,
+  apiUrl,
+  kiezradarFiltersUrl,
+  limitExceeded,
+  onKiezradarSave,
+  ...props
+}) {
   const navigate = useNavigate()
   const [loading, setLoading] = useState(false)
   const [error, setError] = useState(null)
-  const [limitExceeded, setLimitExceeded] = useState(false)
   const [point, setPoint] = useState(kiezradar?.point ?? defaultPoint)
   const [radius, setRadius] = useState(kiezradar?.radius ?? MIN_RADIUS)
 
@@ -52,23 +55,18 @@ export default function Kiezradar ({ kiezradar, onKiezradarSave, ...props }) {
         point,
         radius
       }
-      const url = props.apiUrl + (kiezradar ? kiezradar.id + '/' : '')
+      const url = apiUrl + (kiezradar ? kiezradar.id + '/' : '')
       const method = kiezradar ? 'PATCH' : 'POST'
 
       const response = await updateItem(payload, url, method)
       const data = await response.json()
 
-      if (data.non_field_errors) {
-        setLimitExceeded(true)
-        throw new Error(errorLimitedExceededText)
-      }
-
       if (!response.ok) {
         throw new Error(errorUpdateKiezText)
       }
 
       onKiezradarSave(data)
-      navigate(props.kiezradarFiltersUrl)
+      navigate(kiezradarFiltersUrl)
     } catch (err) {
       setError(err.message)
     } finally {
@@ -115,7 +113,7 @@ export default function Kiezradar ({ kiezradar, onKiezradarSave, ...props }) {
             <button
               className="button"
               type="submit"
-              disabled={loading || limitExceeded}
+              disabled={loading || (!kiezradar && limitExceeded)}
             >
               {loading ? savingText + '...' : saveText}
             </button>

meinberlin/react/kiezradar/KiezradarList.jsx

@@ -9,7 +9,6 @@ const noSavedKiezradarsText = django.gettext('No saved Kiezes')
 const addKiezText = django.gettext('Add Kiez')
 const yourKiezradarsText = django.gettext('Your Kiezes')
 const errorText = django.gettext('Error')
-const errorKiezesText = django.gettext('Failed to fetch Kiezes')
 const errorDeleteKiezesText = django.gettext(
   'Failed to delete kiezradar'
 )
@@ -30,36 +29,14 @@ export default function KiezradarList ({
   planListUrl,
   kiezradarFiltersUrl,
   kiezradarNewUrl,
+  kiezradars,
+  limitExceeded,
   onKiezradarDelete
 }) {
-  const [kiezradars, setKiezradars] = useState([])
   const [loading, setLoading] = useState(false)
   const [error, setError] = useState(null)
   const [deleteModal, setDeleteModal] = useState(null)
 
-  useEffect(() => {
-    const fetchKiezradars = async () => {
-      try {
-        setLoading(true)
-        setError(null)
-
-        const response = await fetch(apiUrl)
-
-        if (!response.ok) {
-          throw new Error(errorKiezesText)
-        }
-
-        const data = await response.json()
-        setKiezradars(data)
-      } catch (err) {
-        setError(err.message)
-      } finally {
-        setLoading(false)
-      }
-    }
-    fetchKiezradars()
-  }, [])
-
   const handleDelete = async (kiezradar) => {
     try {
       setLoading(true)
@@ -71,10 +48,6 @@ export default function KiezradarList ({
         throw new Error(errorDeleteKiezesText)
       }
 
-      setKiezradars((prevKiezradars) =>
-        prevKiezradars.filter((prevKiezradar) => prevKiezradar.id !== kiezradar.id)
-      )
-
       onKiezradarDelete(kiezradar)
     } catch (err) {
       setError(err.message)
@@ -157,12 +130,19 @@ export default function KiezradarList ({
                         </ul>
                       </section>
                       <div className="kiezradar-list__button-container">
-                        <Link
-                          to={kiezradarNewUrl}
-                          className="button kiezradar-list__button"
-                        >
-                          {addKiezText}
-                        </Link>
+                        {limitExceeded
+                          ? (
+                            <button className="button" disabled>
+                              {addKiezText}
+                            </button>
+                            )
+                          : (
+                            <Link
+                              to={kiezradarNewUrl}
+                              className="button"
+                            >
+                              {addKiezText}
+                            </Link>)}
                       </div>
                     </>
                     )}