[#8752] Add kiezradar filter options on project overview #6057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevfurneaux
force-pushed
the
sf-2025-02-kiezradar-dropdown
branch
from
2f158e8 to
3db626f
Compare
sevfurneaux
changed the title
vellip
force-pushed
the
sf-2025-02-kiezradar-dropdown
branch
from
a186345 to
e32c5ae
Compare
sevfurneaux
force-pushed
the
sf-2025-02-kiezradar-dropdown
branch
from
e4b8698 to
5460fac
Compare
sevfurneaux
changed the title
sevfurneaux
force-pushed
the
sf-2025-02-kiezradar-dropdown
branch
5 times, most recently
from
74c1082 to
c68a986
Compare
sevfurneaux
commented
Feb 20, 2025
| import { classNames } from 'adhocracy4' | ||
| import useCombobox from 'adhocracy4/adhocracy4/static/forms/useCombobox' | ||
|
|
||
| export const GroupMultiSelect = ({ |
There was a problem hiding this comment.
Thanks for your help with the multiselect, @hom3mad3. It was quite different from the existing MultiSelect component, so created a new GroupMultiSelect component.
sevfurneaux
force-pushed
the
sf-2025-02-kiezradar-dropdown
branch
from
c68a986 to
a59a173
Compare
hom3mad3
approved these changes
Feb 20, 2025
sevfurneaux
force-pushed
the
sf-2025-02-kiezradar-dropdown
branch
from
09dfe84 to
ca598d7
Compare
vellip
approved these changes
Feb 21, 2025
Comment on lines
49
to
68
| <ul className="a4-combo-box__group-dropdown"> | ||
| {choices.map((choice) => { | ||
| const { active, focused, ...attrs } = getChoicesAttr(choice) | ||
| const liClasses = classNames( | ||
| liClassName, | ||
| 'a4-combo-box__option', | ||
| active && 'a4-combo-box__option--active', | ||
| focused && 'a4-combo-box__option--focus' | ||
| ) | ||
|
|
||
| return ( | ||
| <li key={choice.value} className={liClasses} {...attrs}> | ||
| <span>{choice.name}</span> | ||
| {active && ( | ||
| <i className="bicon bicon-check" aria-hidden="true" /> | ||
| )} | ||
| </li> | ||
| ) | ||
| })} | ||
| </ul> |
There was a problem hiding this comment.
This generates an empty list if there are no items. Can you wrap it in an if?
There was a problem hiding this comment.
@vellip thanks for finding this...
There was a problem hiding this comment.
Thanks, this is now changed 👍
sevfurneaux
force-pushed
the
sf-2025-02-kiezradar-dropdown
branch
from
ca598d7 to
17c263a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds kiezradars as filter options on the project overview.
Tasks