Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8872] Add modal and save filters on login redirect #6098

Merged

Conversation

sevfurneaux
Copy link
Collaborator

Describe your changes
This PR adds a modal if user isn't logged in and saves the project overview filters on login redirect.

Screenshot 2025-02-18 at 07 16 53

Tasks

  • PR name contains story or task reference
  • Steps to recreate and test the changes
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@sevfurneaux sevfurneaux self-assigned this Feb 18, 2025
@sevfurneaux
Copy link
Collaborator Author

Worth noting, this is branched off #6077

@sevfurneaux sevfurneaux force-pushed the sf-2025-02-add-modal-and-save-filters-on-login-redirect branch from 71f8bd0 to 721468e Compare February 18, 2025 07:24
Copy link
Contributor

@hom3mad3 hom3mad3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sevfurneaux
Copy link
Collaborator Author

Thanks @hom3mad3!

Base automatically changed from sf-2025-02-set-params-in-project-overview to dev February 19, 2025 09:48
@sevfurneaux sevfurneaux force-pushed the sf-2025-02-add-modal-and-save-filters-on-login-redirect branch from c87b18b to 721468e Compare February 19, 2025 10:13
@sevfurneaux sevfurneaux merged commit 45f2f76 into dev Feb 19, 2025
2 checks passed
@sevfurneaux sevfurneaux deleted the sf-2025-02-add-modal-and-save-filters-on-login-redirect branch February 19, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants