WIP filters: when invalid filter value, use default value if there is one #1308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from ff64537 |
fuzzylogic2000
approved these changes
Dec 30, 2022
Contributor
fuzzylogic2000
left a comment
fuzzylogic2000
left a comment
There was a problem hiding this comment.
Very nice!
Do you want to add the tests here or later? 🙃
Rineee
changed the title
Contributor
Author
|
So this is not working, the tests are failing as it still takes the ordering by pks.. maybe this could help? https://django-filter.readthedocs.io/en/stable/ref/filterset.html#custom-forms-using-form |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the filter argument is invalid, django adds and shows the label 'All', also in the case that this isnt a 'real' choice.
With this, it would now use the default value of the filter if there is one.