Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use topics enum instead of tuples #1514

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Use topics enum instead of tuples #1514

merged 1 commit into from
Dec 11, 2023

Conversation

m4ra
Copy link
Contributor

@m4ra m4ra commented Dec 7, 2023

Tasks

  • PR name contains story or task reference
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@m4ra m4ra requested a review from goapunk December 7, 2023 13:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023 •
edited
Loading

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 12.85% 141/1097
🔴 Branches 14.86% 103/693
🔴 Functions 12.57% 44/350
🔴 Lines 20.58% 725/3523

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 10a677a

@m4ra m4ra force-pushed the mk-2023-12-use-topics-enum-in-migration branch from a00557f to 10a677a Compare December 11, 2023 10:02
@m4ra m4ra requested a review from goapunk December 11, 2023 10:02
goapunk
goapunk approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@m4ra m4ra changed the title WIP use topics enum instead of tuples Use topics enum instead of tuples Dec 11, 2023
@goapunk goapunk merged commit 68cbb8d into main Dec 11, 2023
2 checks passed
@goapunk goapunk deleted the mk-2023-12-use-topics-enum-in-migration branch December 11, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goapunk goapunk goapunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m4ra @goapunk