projects: add contact details flag to ProjectContactDetailMixin #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m4ra @partizipation @vellip I needed to clean up the templates for the contact information refactor liqd/a4-meinberlin#6030 and ended up making those changes. i would love an opinion on whether this is something we should do at all. and happy to get suggestions on best practices as i learn more about django backend specifics 🧑🎓 coverages decrease a little, should i add tests? |
vellip
reviewed
Feb 3, 2025
hom3mad3
force-pushed
the
mr-2025-01-project-info
branch
from
7a61cba to
814fe50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added because of liqd/a4-meinberlin#6030