Skip to content

feat: HTTP healthcheck on EKS GatewayServer#3250

Merged
adamjensenbot merged 2 commits into
liqotech:masterfrom
fra98:frt/avoid-tcp-healtheck-aws
May 27, 2026
Merged

feat: HTTP healthcheck on EKS GatewayServer#3250
adamjensenbot merged 2 commits into
liqotech:masterfrom
fra98:frt/avoid-tcp-healtheck-aws

Conversation

@fra98

@fra98 fra98 commented Apr 9, 2026

Copy link
Copy Markdown
Member

Description

  • Remove the dedicated EKS gateway server template and unify into the single standard template. Instead of maintaining a separate Helm template for EKS, the EKS-specific NLB annotations (healthcheck config, load balancer type, scheme, etc.) are now injected via liqoctl install eks values.
  • Add ServiceAnnotations and ServiceLabels fields to the GatewayServer CRD, allowing users to customize the gateway Service metadata directly from the CR spec without modifying the server template.
  • Switch EKS healthcheck from TCP to HTTP (/healthz on port 8083), avoiding creating the extra dummy server (e.g., nginx) to pass the TCP health check
  • Update docs to recommend the AWS Load Balancer Controller and document the legacy in-tree fallback annotations.

@adamjensenbot

Copy link
Copy Markdown
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@github-actions github-actions Bot added the feat Adds a new feature to the codebase label Apr 9, 2026
@fra98 fra98 changed the title feat: add support for gw annotations feat: HTTP healthcheck on EKS GatewayServer Apr 9, 2026
@fra98

fra98 commented Apr 22, 2026

Copy link
Copy Markdown
Member Author

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the frt/avoid-tcp-healtheck-aws branch from 78344da to 69d84de Compare April 22, 2026 15:17
@fra98 fra98 force-pushed the frt/avoid-tcp-healtheck-aws branch from 69d84de to 655a3bc Compare April 22, 2026 16:37
@fra98 fra98 marked this pull request as ready for review April 22, 2026 16:37
@fra98

fra98 commented May 26, 2026

Copy link
Copy Markdown
Member Author

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the frt/avoid-tcp-healtheck-aws branch from 655a3bc to 2845b8d Compare May 26, 2026 15:10
@fra98 fra98 force-pushed the frt/avoid-tcp-healtheck-aws branch from 2845b8d to cc96fe1 Compare May 26, 2026 16:48
@fra98

fra98 commented May 26, 2026

Copy link
Copy Markdown
Member Author

/test

@fra98

fra98 commented May 27, 2026

Copy link
Copy Markdown
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label May 27, 2026
@adamjensenbot adamjensenbot merged commit 7e365e9 into liqotech:master May 27, 2026
15 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat Adds a new feature to the codebase size/XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants