Issue1239

[lisphilar]

Related issues

#1239

What was changed

Close #1239

[sourcery-ai]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.72%.

Quality metrics	Before	After	Change
Complexity	2.57 ⭐	2.53 ⭐	-0.04 👍
Method Length	120.69 😞	134.07 😞	13.38 👎
Working memory	9.69 🙂	9.81 🙂	0.12 👎
Quality	61.43% 🙂	60.71% 🙂	-0.72% 👎

Other metrics	Before	After	Change
Lines	583	652	69

Changed files	Quality Before	Quality After	Quality Change
covsirphy/science/ode_scenario.py	57.02% 🙂	57.86% 🙂	0.84% 👍
tests/test_science/test_ode_scenario.py	81.86% ⭐	79.55% ⭐	-2.31% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
covsirphy/science/ode_scenario.py	ODEScenario.compare_cases	5 ⭐	357 ⛔	14 😞	40.17% 😞	Try splitting into smaller methods. Extract out complex expressions
covsirphy/science/ode_scenario.py	ODEScenario._append	6 ⭐	303 ⛔	12 😞	43.55% 😞	Try splitting into smaller methods. Extract out complex expressions
covsirphy/science/ode_scenario.py	ODEScenario.compare_param	4 ⭐	232 ⛔	14 😞	45.67% 😞	Try splitting into smaller methods. Extract out complex expressions
covsirphy/science/ode_scenario.py	ODEScenario.represent	4 ⭐	217 ⛔	13 😞	48.02% 😞	Try splitting into smaller methods. Extract out complex expressions
covsirphy/science/ode_scenario.py	ODEScenario.predict	1 ⭐	242 ⛔	13 😞	49.50% 😞	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[codecov]

Codecov Report

Merging #1240 (d37d3ed) into master (80101f4) will increase coverage by 3.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1240      +/-   ##
==========================================
+ Coverage   87.07%   90.32%   +3.24%     
==========================================
  Files          43       43              
  Lines        2840     2872      +32     
==========================================
+ Hits         2473     2594     +121     
+ Misses        367      278      -89     

Impacted Files	Coverage Δ
covsirphy/science/ode_scenario.py	56.66% <100.00%> (+41.12%)	⬆️
covsirphy/util/error.py	77.56% <0.00%> (+1.28%)	⬆️
covsirphy/util/alias.py	93.10% <0.00%> (+10.34%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.