Skip to content

revert test skip and use pandas 1.5.1#1289

Merged
lisphilar merged 2 commits intomainfrom
issue1233
Oct 22, 2022
Merged

revert test skip and use pandas 1.5.1#1289
lisphilar merged 2 commits intomainfrom
issue1233

Conversation

@lisphilar
Copy link
Copy Markdown
Owner

Related issues

#1233

What was changed

Close #1233 by reverting test skip and use pandas version 1.5.1.

@lisphilar lisphilar added bug Something isn't working dependencies Pull requests that update a dependency file labels Oct 22, 2022
@lisphilar lisphilar added this to the Release v3.0.0 milestone Oct 22, 2022
@lisphilar lisphilar added development Add tests or refactoring and removed bug Something isn't working labels Oct 22, 2022
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Oct 22, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 1.11%.

Quality metrics Before After Change
Complexity 0.00 ⭐ 0.00 ⭐ 0.00
Method Length 46.25 ⭐ 43.75 ⭐ -2.50 👍
Working memory 4.84 ⭐ 4.58 ⭐ -0.26 👍
Quality 85.90% 87.01% 1.11% 👍
Other metrics Before After Change
Lines 26 25 -1
Changed files Quality Before Quality After Quality Change
tests/test_visualization/test_scatter.py 85.90% ⭐ 87.01% ⭐ 1.11% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 22, 2022

Codecov Report

Merging #1289 (9810751) into main (6868841) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1289      +/-   ##
==========================================
+ Coverage   90.91%   90.98%   +0.07%     
==========================================
  Files          42       42              
  Lines        2741     2741              
  Branches      279      279              
==========================================
+ Hits         2492     2494       +2     
+ Misses        231      229       -2     
  Partials       18       18              
Impacted Files Coverage Δ
covsirphy/visualization/scatter_plot.py 100.00% <0.00%> (+4.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lisphilar lisphilar merged commit 2d3c722 into main Oct 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the issue1233 branch October 22, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file development Add tests or refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dev] revert skip test: TestScatterPlot.test_colormap() after pandas 1.5.1 release

1 participant