feat(dashboard): Add task node run information to the sidebard #1950
Conversation
Magol28
force-pushed
the
feat-task-nr
branch
from
ba464b1 to
ff94732
Compare
There was a problem hiding this comment.
I see how cool is to use this magic classes to process colors for each state, although there's something you are missing handling it in this way.
You won't be able to catch when a new status is added in build time. I would suggest to change this to a typed data and not use css
| export const NodeStatus = ({ status }: { status: LHStatus }) => { | ||
|
|
||
| export const NodeStatus = ({ status, type }: { status: LHStatus | TaskStatus; type?: string }) => { | ||
| const statusType = type === 'task' ? `task-status--${status.toUpperCase()}` : `node-status--${status.toLowerCase()}` |
There was a problem hiding this comment.
why some are lowercase and others uppercase?
This is where if you don't use a typed data structure, you won't catch when a new status is added during build time. Use typed data instead of classNames as strings.
| export const getAttemptOutput = (output: VariableValue | undefined): string => { | ||
| if (!output?.value?.value) return 'No Output' | ||
| return String(getVariableValue(output)) | ||
| } | ||
|
|
||
| export const getAttemptResult = ( | ||
| result: | ||
| | { $case: 'output'; value: VariableValue } | ||
| | { $case: 'error'; value: any } | ||
| | { $case: 'exception'; value: any } | ||
| | undefined | ||
| ): string => { | ||
| if (!result) return 'No Output' | ||
|
|
||
| if (result.$case === 'output') { | ||
| return getAttemptOutput(result.value) | ||
| } | ||
|
|
||
| // For error/exception, prefer a message property if present, otherwise fallback to JSON | ||
| const val = result.value | ||
| return (val && (val.message ?? val.msg ?? val.toString())) || JSON.stringify(val) || 'No Output' | ||
| } |
There was a problem hiding this comment.
What is this? you should use the types from the littlehorse-client library. Also avoid using any
| const { tenantId } = useWhoAmI() | ||
| const [nodeTask, setNodeTask] = useState<TaskRun>() | ||
| const [attemptIndex, setAttemptIndex] = useState(0) | ||
| useLayoutEffect(() => { |
There was a problem hiding this comment.
You shouldn't use useLayoutEffect this must be handled by SWR.
The task node information is available on the sidebard
