Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify broadcast extension setup with standard format for identifiers #573

Merged
merged 5 commits into from
Feb 13, 2025

Conversation

ladvoc
Copy link
Contributor

@ladvoc ladvoc commented Feb 4, 2025

When configuring a broadcast extension, manually setting the info keys RTCAppGroupIdentifier and RTCScreenSharingExtension is no longer required when using the standard format. The standard format is as follows:

  • App group: group.<main-app-bundle-id>
  • Broadcast extension: <main-app-bundle-id>.broadcast

Copy link
Contributor

@bcherry bcherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great and thank you for updating the docs!

@ladvoc ladvoc mentioned this pull request Feb 7, 2025
hiroshihorie added a commit that referenced this pull request Feb 13, 2025
- Add version and platform compatibility badges from [Swift Package
Index](https://swiftpackageindex.com/) to README
  - Automatically updated on each release 
- Add [nanpa](https://github.com/nbsp/nanpa) configuration
- Custom script bumps version across repo (currently Podspec, README,
and LiveKitSDK class)
  - GitHub publish workflow (based on workflow from livekit/rust-sdks)
- Create workflow to push new releases to Cocopods when a release is
published on GitHub

I have also added changeset files to my currently open PRs (#565, #576,
and #573) that can be used to test this configuration.

---------

Co-authored-by: Hiroshi Horie <[email protected]>
@hiroshihorie hiroshihorie merged commit aa0a21d into livekit:main Feb 13, 2025
11 of 12 checks passed
hiroshihorie added a commit to ladvoc/client-sdk-swift that referenced this pull request Feb 13, 2025
commit aa0a21d
Author: Jacob Gelman <[email protected]>
Date:   Thu Feb 13 06:28:21 2025 -0800

    Simplify broadcast extension setup with standard format for identifiers (livekit#573)

    When configuring a broadcast extension, manually setting the info keys
    `RTCAppGroupIdentifier` and `RTCScreenSharingExtension` is no longer
    required when using the standard format. The standard format is as
    follows:
    - App group: `group.<main-app-bundle-id>`
    - Broadcast extension: `<main-app-bundle-id>.broadcast`

    ---------

    Co-authored-by: Hiroshi Horie <[email protected]>

commit c3ee701
Author: Jacob Gelman <[email protected]>
Date:   Thu Feb 13 06:05:00 2025 -0800

    Deprecate public broadcast picker extension (livekit#586)

    Public show method defined as an extension to
    `RPSystemBroadcastPickerView` has been deprecated in favor of
    `BroadcastManager.shared.requestActivation()`.

    ---------

    Co-authored-by: Hiroshi Horie <[email protected]>

commit 0da6660
Author: Jacob Gelman <[email protected]>
Date:   Thu Feb 13 05:55:25 2025 -0800

    Release automation (livekit#579)

    - Add version and platform compatibility badges from [Swift Package
    Index](https://swiftpackageindex.com/) to README
      - Automatically updated on each release
    - Add [nanpa](https://github.com/nbsp/nanpa) configuration
    - Custom script bumps version across repo (currently Podspec, README,
    and LiveKitSDK class)
      - GitHub publish workflow (based on workflow from livekit/rust-sdks)
    - Create workflow to push new releases to Cocopods when a release is
    published on GitHub

    I have also added changeset files to my currently open PRs (livekit#565, livekit#576,
    and livekit#573) that can be used to test this configuration.

    ---------

    Co-authored-by: Hiroshi Horie <[email protected]>

commit 5b031c8
Author: Hiroshi Horie <[email protected]>
Date:   Thu Feb 13 22:36:35 2025 +0900

    Update Podspec (livekit#587)

    Fixes: livekit#566

commit 485e76d
Author: Hiroshi Horie <[email protected]>
Date:   Wed Feb 12 14:36:48 2025 +0900

    macOS screen share audio (livekit#561)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants