Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for v2 #5

Merged
merged 16 commits into from
Feb 26, 2024
Merged

Update for v2 #5

merged 16 commits into from
Feb 26, 2024

Conversation

hiroshihorie
Copy link
Member

No description provided.

@hiroshihorie
Copy link
Member Author

hiroshihorie commented Feb 19, 2024 •
edited
Loading

After consideration, removed state builders ConnectionQualityBuilder and ConnectionStateBuilder since it doesn't really solve a problem and it just complicates the logic.

davidzhao
davidzhao approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@hiroshihorie hiroshihorie merged commit e7b1496 into main Feb 26, 2024
@hiroshihorie hiroshihorie deleted the v2-update branch February 26, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiroshihorie @davidzhao