Merged
Conversation
* Can set both ipv4 and ipv6 addr in NodeIP by "node_ip: <v4>, <v6>" * Resolve ipv6 addr by stun server when use_external_ip is true
boks1971
approved these changes
Mar 9, 2026
pkg/rtcconfig/config.go
Outdated
| return n.V4 == "" && n.V6 == "" | ||
| } | ||
|
|
||
| func (n *NodeIP) ToSlice() []string { |
Contributor
There was a problem hiding this comment.
:nit: rename to ToStringSlice
cnderrauber
added a commit
that referenced
this pull request
Apr 9, 2026
The ip filter is not applied before but #79 will include ipv6 addr, it could use internal ip to ping stun server and cause problem livekit/livekit#4437
cnderrauber
added a commit
that referenced
this pull request
Apr 9, 2026
The ip filter is not applied before but #79 will include ipv6 addr, it could use internal ip to ping stun server and cause problem livekit/livekit#4437
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node_ip: <v4>, <v6>