Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ai): add missing aiServiceRegistry flag #3363

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

rickstaa
Copy link
Member

@rickstaa rickstaa commented Jan 21, 2025

What does this pull request do? Explain your changes. (required)

This pull request ensures the aiServiceRegistry flag is added to the example JSON, which is required to connect to the AI network. It also improves the AI VSCode launch.json example by using a separate data directory for the gateway and removes the unused transcodingOptions flag, resulting in a cleaner and more organized configuration.

Specific updates (required)

  • Updated doc/development.md.

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

@github-actions github-actions bot added the docs label Jan 21, 2025
@rickstaa rickstaa force-pushed the update_dev_docs branch 2 times, most recently from f784c87 to 3dba5ee Compare January 21, 2025 10:10
@rickstaa rickstaa requested a review from eliteprox January 21, 2025 10:10
This pull request ensures the `aiServiceRegistry` flag is added to the
example JSON, which is required to connect to the AI network. It also
improves the AI VSCode `launch.json` example by using a separate data
directory for the gateway and removes the unused `transcodingOptions` flag,
resulting in a cleaner and more organized configuration.
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.71627%. Comparing base (8d48192) to head (09f420d).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3363         +/-   ##
===================================================
- Coverage   33.72602%   33.71627%   -0.00975%     
===================================================
  Files            141         141                 
  Lines          37434       37430          -4     
===================================================
- Hits           12625       12620          -5     
- Misses         24088       24089          +1     
  Partials         721         721                 

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b091068...09f420d. Read the comment docs.

see 1 file with indirect coverage changes

Copy link
Collaborator

@eliteprox eliteprox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eliteprox eliteprox merged commit 2b32793 into master Jan 21, 2025
18 checks passed
@eliteprox eliteprox deleted the update_dev_docs branch January 21, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants