ai/live: Remote signer discovery #3866
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j0sh
force-pushed
the
ja/remote-discovery
branch
from
d63d90f to
8b60101
Compare
This requires threading through an additional field for each of the discovery types to pass into the OrchestratorInfo request. The behavior for non-discovery gateways should remain the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional discovery endpoint to the remote signer node.
Can be enabled by setting any of these flags:
orchAddrremoteOrchDiscovery(new with this PR)This effectively makes discovery opt-in since I'm not entirely sure that remote signers will want to expose discovery unconditionally.
If a gateway is configured with a remote signer URL but no other orchestrators, it will use the signer's discovery endpoint as the orchestrator web hook URL.