Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dialects to list #490

Merged
merged 12 commits into from
Oct 1, 2024
Merged

Add dialects to list #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
54aa2a9
Revert table view speakers
Danble Aug 13, 2024
9915520
Merge branch 'main' of github.com:livingtongues/living-dictionaries
Danble Aug 13, 2024
df3999e
Merge branch 'main' of github.com:livingtongues/living-dictionaries
Danble Aug 13, 2024
8a46c27
Merge branch 'main' of github.com:livingtongues/living-dictionaries
Danble Aug 23, 2024
3dbd830
Merge branch 'main' of github.com:livingtongues/living-dictionaries
Danble Aug 26, 2024
051dde3
Merge branch 'main' of github.com:livingtongues/living-dictionaries
Danble Aug 30, 2024
7b61a39
update speakers refactor file
Danble Aug 30, 2024
82115ff
Merge branch 'main' of github.com:livingtongues/living-dictionaries
Danble Aug 30, 2024
36f16e3
Merge branch 'main' of github.com:livingtongues/living-dictionaries
Danble Sep 3, 2024
caca23f
Merge branch 'main' of github.com:livingtongues/living-dictionaries
Danble Sep 12, 2024
5127027
add dialects to entry list for all dictionaries, not only Jewish Neo-…
Danble Oct 1, 2024
53323ec
update ListEntry variant
Danble Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/site/src/routes/[dictionaryId]/entries/list/ListEntry.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,11 @@
{/if}
{/if}

{#if entry.dialects}<p class="text-xs">
<i class="mr-1">{$page.data.t('entry_field.dialects')}: {entry.dialects.join(', ')}</i>
</p>{/if}

{#if dictionary.id === 'jewish-neo-aramaic'}
{#if entry.dialects}<p class="text-xs">
<i class="mr-1">{$page.data.t('entry_field.dialects')}: {entry.dialects.join(', ')}</i>
</p>{/if}
{#each entry.senses?.[0]?.example_sentences || [{}] as sentence}
{#each Object.entries(sentence) as [bcp, content]}
<p>
Expand Down
2 changes: 1 addition & 1 deletion packages/site/src/routes/[dictionaryId]/entries/list/ListEntry.variants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export const Jewish_Neo_Aramaic: Variant<Component> = {
entry: complex,
videoAccess: true,
_meta: {
description: 'This dictionary has an exception where we show dialects and example sentences in the list view.',
description: 'This dictionary has an exception where we show example sentences in the list view.',
},
}

Expand Down
Loading