fix: null return for root bounds being null on dom rect #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexh-compyl Thanks for the PR! Will look to get this merged! |
ljbc1994
reviewed
Jan 6, 2025
| @@ -68,6 +68,7 @@ function remove(callbackId) { | |||
| } | |||
| function toEntryObject(entry) { | |||
| function toRectReadOnlyObject(obj) { | |||
| if (!obj) return null; | |||
There was a problem hiding this comment.
Could we update /src/index.ts with this change?
Then you can run npm run build which will update the .js file.
There was a problem hiding this comment.
Haha! Sorry about that. I was just debugging it and didn't even think to modify the actual typescript. Change has been made!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the instance root bounds is null on a
DomRectReadOnly, an exception is being thrown. rootBounds can legitimately be null in cases where there is no root intersection observer container defined, which is happening during an operation in our drag and drop implementation.Fixes #49