Fix LLAMA_STACK_LOG in README #246
Conversation
The readme calls to use `LLAMA_STACK_CLIENT_LOG` env var to enable debug logs, but that's not the value we are using in the code [1]. Update it to use the right env var name: `LLAMA_STACK_LOG`. [1]: https://github.com/meta-llama/llama-stack-client-python/blob/52c0b5d23e9ae67ceb09d755143d436f38c20547/src/llama_stack_client/_utils/_logs.py#L19
Akrog
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn,
raghotham,
dineshyv,
vladimirivic,
ehhuang,
SLR722 and
reluctantfuturist
as code owners
|
Hi @Akrog! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
The readme calls to use
LLAMA_STACK_CLIENT_LOGenv var to enable debug logs, but that's not the value we are using in the code 1.Update it to use the right env var name:
LLAMA_STACK_LOG.One could argue that
LLAMA_STACK_CLIENT_LOGis a better name (considering llama-stack usesLLAMA_STACK_LOGGING), but if we want to change it we'll need to allow using both, which is easy enough to do if that's what we want: