Pin FMA+KEDA workloads to a target node for benchmarking - #1883
Draft
dumb0002 wants to merge 1 commit into
Draft
Conversation
Adds explicit node targeting for the FMA launcher/requester workloads so a benchmark can be confined to one node, including a tainted one: Signed-off-by: dumb0002 <Braulio.Dumba@ibm.com>
dumb0002
force-pushed
the
fma-keda-beanchmarking
branch
from
September 3, 2026 18:30
4a6d822 to
3b59c45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confines an FMA+KEDA benchmark to a single node — including a tainted, admin-reserved one — so load generation and other tenants can't perturb the measurements.
Node name, label, and tolerations are set in one place: the new top-level nodePinning block in
config/templates/values/defaults.yaml. Filling it in places the FMA launchers, the FMA requester, and EPP on that node; no per-scenario edits. The block is inert while enabled: false.FMA launchers and requester
EPP
_apply_epp_node_pinning()inrender_plans.pyinjects EPP's placement from the same block. The router chart exposes affinity and tolerations for EPP but no nodeSelector, so node selection becomes a nodeAffinity term there while the FMA requester uses nodeSelector — different syntax, same effect. Adding router.epp.nodeSelector would be silently ignored, which is why this is done in the renderer rather than left to scenario authors.