test(pvc-evictor): add coverage for Config.from_env() - #719
Open
magic-peach wants to merge 1 commit into
Open
Conversation
The other four modules in this component have a test file; config.py had none, despite from_env() doing env var parsing, default fallbacks, and numeric string coercion for several fields. Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
magic-peach
requested review from
dannyharnik,
kfirtoledo,
liu-cong and
vMaroon
as code owners
September 8, 2026 19:33
github-actions
Bot
added
the
size/M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The other four modules in this component have a test file; config.py had none, despite from_env() doing env var parsing, default fallbacks, and numeric string coercion for several fields.
Tested: ran the new tests directly with pytest, both pass (test_from_env_defaults, test_from_env_overrides_and_numeric_coercion).