feat(metrics): enhance cache efficiency metrics - #720
Open
JaredTan95 wants to merge 1 commit into
Open
Conversation
JaredTan95
requested review from
dannyharnik,
kfirtoledo,
liu-cong and
vMaroon
as code owners
September 10, 2026 08:18
|
Unsigned commits detected! Please sign your commits. For instructions on how to set up GPG/SSH signing and verify your commits, please see GitHub Documentation. |
Signed-off-by: JaredTan95 <jian.tan@daocloud.io>
JaredTan95
force-pushed
the
cache-efficiency-metrics
branch
from
September 10, 2026 08:21
2e3d7de to
43ea0c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #617.
Completes Sub-issue 3: Cache Efficiency Metrics Enhancement.
The index previously exposed aggregate admission/eviction counters without backend attribution or explicit cache efficiency gauges. This change adds a
backendlabel to the existing counters and introduceskvcache_index_entriesandkvcache_index_hit_rategauges through the existing metrics registry.in_memory,cost_aware_memory,redis, andvalkeybackends, withunknownfor custom index implementations. Metrics logging continues to aggregate admissions and evictions across backend series.lookup_hits_total / lookup_requests_totalvalues; it is not an independently calculated per-backend hit ratio.Existing counter metric names are preserved; consumers now receive backend-labeled series and can use
sum(...)to retain aggregate views.Validation:
go test ./pkg/kvcache/metrics ./pkg/kvcache/kvblockgo test -race ./pkg/kvcache/kvblockgit diff --check