Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IR] LangRef: state explicitly that floats generally behave according to IEEE-754 #102140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IR] LangRef: state explicitly that floats generally behave according to IEEE-754 #102140
Changes from 5 commits
d643f2c
648d3ce
d107aa0
cd80e84
7d4deb8
29f5c14
f909f35
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the denormal exception
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the denormal exception? Is this about what happens when
denormal-fp-math
is set, but the default is to be IEEE-compatible?Given that IEEE says that denormals are not flushed and LLVM assumes the same by default, I don't think this is an exception from "IR float ops behave according to IEEE".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph is basically an exact duplicate of the second paragraph in the
floatenv
section, so I am inclined to remove it... but your draft did include such a sentence.The way I view it, the
floatsem
section is just about the IEEE float formats. This paragraph is true for all formats so it should be in thefloatenv
section.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Term is usually "correctly rounded" not "perfectly rounded"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, fair. It should be clear from context who is in charge of defining "correct" here (namely, IEEE-754).
I am adding these edits as new commits so it's easy to see what changed; I can squash them later or now if you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and metadata (e.g. !fpmath)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I didn't know about that one, thanks. I added a mention, and also used the opportunity to add links for
strictfp
anddenormal-fp-math
.