Skip to content

[Github] Add some additional system packages #119988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

boomanaiden154
Copy link
Contributor

This patch adds some additional system packages to the CI container. These are necessary for use in the new premerge workflows. The size increase is not super small, but should be manageable with the size increase being about 100MB.

This patch adds some additional system packages to the CI container. These
are necessary for use in the new premerge workflows. The size increase is
not super small, but should be manageable with the size increase being about
100MB.
@llvmbot
Copy link
Member

llvmbot commented Dec 14, 2024

@llvm/pr-subscribers-github-workflow

Author: Aiden Grossman (boomanaiden154)

Changes

This patch adds some additional system packages to the CI container. These are necessary for use in the new premerge workflows. The size increase is not super small, but should be manageable with the size increase being about 100MB.


Full diff: https://github.com/llvm/llvm-project/pull/119988.diff

1 Files Affected:

  • (modified) .github/workflows/containers/github-action-ci/Dockerfile (+7-3)
diff --git a/.github/workflows/containers/github-action-ci/Dockerfile b/.github/workflows/containers/github-action-ci/Dockerfile
index da11803cad1042..67bc5b2b0909e7 100644
--- a/.github/workflows/containers/github-action-ci/Dockerfile
+++ b/.github/workflows/containers/github-action-ci/Dockerfile
@@ -41,13 +41,13 @@ RUN ninja -C ./build stage2-clang-bolt stage2-install-distribution && ninja -C .
 FROM base
     
 COPY --from=stage1-toolchain $LLVM_SYSROOT $LLVM_SYSROOT
-    
+
 # Need to install curl for hendrikmuhs/ccache-action
 # Need nodejs for some of the GitHub actions.
 # Need perl-modules for clang analyzer tests.
 # Need git for SPIRV-Tools tests.
 RUN apt-get update && \
-    apt-get install -y \
+    DEBIAN_FRONTEND=noninteractive apt-get install -y \
     binutils \ 
     cmake \
     curl \
@@ -56,7 +56,11 @@ RUN apt-get update && \
     ninja-build \
     nodejs \
     perl-modules \
-    python3-psutil
+    python3-psutil \
+    python3-pip \
+    ccache \
+    file \
+    tzdata
 
 ENV LLVM_SYSROOT=$LLVM_SYSROOT
 ENV PATH=${LLVM_SYSROOT}/bin:${PATH}

@boomanaiden154 boomanaiden154 merged commit 1751914 into llvm:main Dec 16, 2024
4 of 7 checks passed
@boomanaiden154 boomanaiden154 deleted the ci-container-extra-packages branch December 16, 2024 20:30
mgehre-amd pushed a commit to Xilinx/llvm-project that referenced this pull request Jan 6, 2025
This patch adds some additional system packages to the CI container.
These are necessary for use in the new premerge workflows. The size
increase is not super small, but should be manageable with the size
increase being about 100MB.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants