Skip to content

[flang] Adding a couple of tests to the alias analysis #125917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

Renaud-K
Copy link
Contributor

@Renaud-K Renaud-K commented Feb 5, 2025

To establish a baseline for new tests mentioned in #117785, adding them here independently.

@llvmbot llvmbot added the flang Flang issues not falling into any other category label Feb 5, 2025
@Renaud-K Renaud-K changed the title Adding a couple of tests to the alias analysis [flang] Adding a couple of tests to the alias analysis Feb 5, 2025
Copy link
Contributor

@jeanPerier jeanPerier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me be conservative here for now, thanks!

@Renaud-K Renaud-K merged commit 8d5f280 into llvm:main Feb 6, 2025
10 checks passed
@@ -47,6 +47,14 @@
// CHECK-DAG: arg2.load#0 <-> arg2.addr#0: MustAlias
// CHECK-DAG: boxp1.addr#0 <-> arg2.addr#0: MayAlias

// TODO: Can the address in a pointer alias the address of a pointer, even when the
// pointer has no box. Should this be NoAlias?
// T3: CHECK-DAG: p1.addr#0 <-> p1.tgt#0: MayAlias
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want "T3" and "T4" to appear in comments when landing upstream?

I wrote those just to guide discussion of #117785.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoot no. I missed that. I will post a new review.

@Renaud-K Renaud-K deleted the aa-tests branch February 6, 2025 18:47
Icohedron pushed a commit to Icohedron/llvm-project that referenced this pull request Feb 11, 2025
To establish a baseline for new tests mentioned in
llvm#117785, adding them here
independently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants