Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMDGPU][docs][NFC] Replace gfx940 with gfx942 in the gfx940 ISA doc #126906

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

ritter-x2a
Copy link
Member

gfx940 and gfx941 are no longer supported. This is the last one of a
series of PRs to remove them from the code base.

The ISA documentation still contains a lot of links and file names with
the "gfx940" identifier. Changing them to "gfx942" is probably not worth
the cost of breaking all URLs to these pages that users might have saved
in the past.

For SWDEV-512631

Copy link
Member Author

Let me know if you think that this PR should also update labels and file names like, for example, gfx940_imm16_0533c2 (and consequently break existing URLs like https://llvm.org/docs/AMDGPU/gfx940_imm16_0533c2.html )

@llvmbot
Copy link
Member

llvmbot commented Feb 12, 2025

@llvm/pr-subscribers-backend-amdgpu

Author: Fabian Ritter (ritter-x2a)

Changes

gfx940 and gfx941 are no longer supported. This is the last one of a
series of PRs to remove them from the code base.

The ISA documentation still contains a lot of links and file names with
the "gfx940" identifier. Changing them to "gfx942" is probably not worth
the cost of breaking all URLs to these pages that users might have saved
in the past.

For SWDEV-512631


Full diff: https://github.com/llvm/llvm-project/pull/126906.diff

1 Files Affected:

  • (modified) llvm/docs/AMDGPU/AMDGPUAsmGFX940.rst (+2-2)
diff --git a/llvm/docs/AMDGPU/AMDGPUAsmGFX940.rst b/llvm/docs/AMDGPU/AMDGPUAsmGFX940.rst
index 90797499dec22..7603bcc95383b 100644
--- a/llvm/docs/AMDGPU/AMDGPUAsmGFX940.rst
+++ b/llvm/docs/AMDGPU/AMDGPUAsmGFX940.rst
@@ -6,7 +6,7 @@
     **************************************************
 
 ====================================================================================
-Syntax of gfx940 Instructions
+Syntax of gfx942 Instructions
 ====================================================================================
 
 .. contents::
@@ -15,7 +15,7 @@ Syntax of gfx940 Instructions
 Introduction
 ============
 
-This document describes the syntax of gfx940 instructions.
+This document describes the syntax of gfx942 instructions.
 
 Notation
 ========

@ritter-x2a ritter-x2a marked this pull request as ready for review February 12, 2025 13:20
@shiltian
Copy link
Contributor

I guess there is no gfx941 in the doc.

@ritter-x2a ritter-x2a force-pushed the users/ritter-x2a/rm-gfx940-gfx941-docs branch from 12460f0 to 6bc2689 Compare February 13, 2025 09:31
@ritter-x2a ritter-x2a force-pushed the users/ritter-x2a/rm-gfx940-gfx941-docs-isa branch from 666b36b to 3be3e8d Compare February 13, 2025 09:31
@ritter-x2a ritter-x2a force-pushed the users/ritter-x2a/rm-gfx940-gfx941-docs branch from 6bc2689 to a5d359b Compare February 13, 2025 14:57
@ritter-x2a ritter-x2a force-pushed the users/ritter-x2a/rm-gfx940-gfx941-docs-isa branch 2 times, most recently from 5bfa81d to f58faa1 Compare February 18, 2025 08:22
@ritter-x2a ritter-x2a force-pushed the users/ritter-x2a/rm-gfx940-gfx941-docs branch from a5d359b to ca4a620 Compare February 18, 2025 08:22
Copy link
Member Author

ritter-x2a commented Feb 19, 2025

Merge activity

  • Feb 19, 3:48 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Feb 19, 4:32 AM EST: Graphite rebased this pull request as part of a merge.
  • Feb 19, 4:35 AM EST: Graphite rebased this pull request as part of a merge.
  • Feb 19, 4:37 AM EST: A user merged this pull request with Graphite.

@ritter-x2a ritter-x2a force-pushed the users/ritter-x2a/rm-gfx940-gfx941-docs branch from ca4a620 to a0b0253 Compare February 19, 2025 09:29
Base automatically changed from users/ritter-x2a/rm-gfx940-gfx941-docs to main February 19, 2025 09:31
@ritter-x2a ritter-x2a force-pushed the users/ritter-x2a/rm-gfx940-gfx941-docs-isa branch from f58faa1 to f503b3e Compare February 19, 2025 09:32
gfx940 and gfx941 are no longer supported. This is the last one of a
series of PRs to remove them from the code base.

The ISA documentation still contains a lot of links and file names with
the "gfx940" identifier. Changing them to "gfx942" is probably not worth
the cost of breaking all URLs to these pages that users might have saved
in the past.

For SWDEV-512631
@ritter-x2a ritter-x2a force-pushed the users/ritter-x2a/rm-gfx940-gfx941-docs-isa branch from f503b3e to 12454d1 Compare February 19, 2025 09:35
@ritter-x2a ritter-x2a merged commit c442b39 into main Feb 19, 2025
6 of 8 checks passed
@ritter-x2a ritter-x2a deleted the users/ritter-x2a/rm-gfx940-gfx941-docs-isa branch February 19, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants