[Github][libc++] Prefer ubuntu-24.04 over ubuntu-latest #129949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch replaces all instances of ubuntu-latest with ubuntu-24.04 based on the guidelines in the LLVM CI best practices doc (https://llvm.org/docs/CIBestPractices.html).
boomanaiden154
requested review from
tstellar,
ldionne,
EricWF,
carlocab and
philnik777
llvmbot
added
libc++
|
@llvm/pr-subscribers-libcxx Author: Aiden Grossman (boomanaiden154) ChangesThis patch replaces all instances of ubuntu-latest with ubuntu-24.04 based on the guidelines in the LLVM CI best practices doc (https://llvm.org/docs/CIBestPractices.html). Full diff: https://github.com/llvm/llvm-project/pull/129949.diff 3 Files Affected:
diff --git a/.github/workflows/libcxx-build-containers.yml b/.github/workflows/libcxx-build-containers.yml
index bb4bd8843772f..b499af943c8e7 100644
--- a/.github/workflows/libcxx-build-containers.yml
+++ b/.github/workflows/libcxx-build-containers.yml
@@ -26,7 +26,7 @@ on:
jobs:
build-and-push:
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
if: github.repository_owner == 'llvm'
permissions:
packages: write
diff --git a/.github/workflows/libcxx-check-generated-files.yml b/.github/workflows/libcxx-check-generated-files.yml
index 570055624b2a8..1f8103a114b9f 100644
--- a/.github/workflows/libcxx-check-generated-files.yml
+++ b/.github/workflows/libcxx-check-generated-files.yml
@@ -9,7 +9,7 @@ permissions:
jobs:
check_generated_files:
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
steps:
- name: Fetch LLVM sources
uses: actions/checkout@v4
diff --git a/.github/workflows/libcxx-restart-preempted-jobs.yaml b/.github/workflows/libcxx-restart-preempted-jobs.yaml
index e7e3772d4de22..7b341d7f22e41 100644
--- a/.github/workflows/libcxx-restart-preempted-jobs.yaml
+++ b/.github/workflows/libcxx-restart-preempted-jobs.yaml
@@ -26,7 +26,7 @@ jobs:
statuses: read
checks: write
actions: write
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
steps:
- name: "Restart Job"
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea #v7.0.1
@@ -161,7 +161,7 @@ jobs:
statuses: read
checks: write
actions: write
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
steps:
- name: "Restart Job (test)"
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea #v7.0.1
|
|
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesThis patch replaces all instances of ubuntu-latest with ubuntu-24.04 based on the guidelines in the LLVM CI best practices doc (https://llvm.org/docs/CIBestPractices.html). Full diff: https://github.com/llvm/llvm-project/pull/129949.diff 3 Files Affected:
diff --git a/.github/workflows/libcxx-build-containers.yml b/.github/workflows/libcxx-build-containers.yml
index bb4bd8843772f..b499af943c8e7 100644
--- a/.github/workflows/libcxx-build-containers.yml
+++ b/.github/workflows/libcxx-build-containers.yml
@@ -26,7 +26,7 @@ on:
jobs:
build-and-push:
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
if: github.repository_owner == 'llvm'
permissions:
packages: write
diff --git a/.github/workflows/libcxx-check-generated-files.yml b/.github/workflows/libcxx-check-generated-files.yml
index 570055624b2a8..1f8103a114b9f 100644
--- a/.github/workflows/libcxx-check-generated-files.yml
+++ b/.github/workflows/libcxx-check-generated-files.yml
@@ -9,7 +9,7 @@ permissions:
jobs:
check_generated_files:
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
steps:
- name: Fetch LLVM sources
uses: actions/checkout@v4
diff --git a/.github/workflows/libcxx-restart-preempted-jobs.yaml b/.github/workflows/libcxx-restart-preempted-jobs.yaml
index e7e3772d4de22..7b341d7f22e41 100644
--- a/.github/workflows/libcxx-restart-preempted-jobs.yaml
+++ b/.github/workflows/libcxx-restart-preempted-jobs.yaml
@@ -26,7 +26,7 @@ jobs:
statuses: read
checks: write
actions: write
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
steps:
- name: "Restart Job"
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea #v7.0.1
@@ -161,7 +161,7 @@ jobs:
statuses: read
checks: write
actions: write
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
steps:
- name: "Restart Job (test)"
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea #v7.0.1
|
carlocab
approved these changes
Mar 6, 2025
mordante
requested changes
Mar 6, 2025
|
@mordante I feel like you're sending mixed messages here. |
Thanks for catching this, it seems I selected the wrong item. |
I fixed these by manually combing over the repo. I'm planning on looking into setting up some automation for upgrading things, but need to do some more thinking on how exactly we want to do it. |
jph-13
pushed a commit
to jph-13/llvm-project
that referenced
this pull request
Mar 21, 2025
This patch replaces all instances of ubuntu-latest with ubuntu-24.04 based on the guidelines in the LLVM CI best practices doc (https://llvm.org/docs/CIBestPractices.html).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces all instances of ubuntu-latest with ubuntu-24.04 based on the guidelines in the LLVM CI best practices doc (https://llvm.org/docs/CIBestPractices.html).