Skip to content

[flang] Fix crash in defined I/O table creation #173783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
klausler wants to merge 1 commit into
base: main
Choose a base branch
from
+41 −7
Open

[flang] Fix crash in defined I/O table creation #173783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions flang/lib/Semantics/runtime-type-info.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1394,13 +1394,19 @@ CollectNonTbpDefinedIoGenericInterfaces(
// scope has an equivalent type, use it for the table rather
// than the "dtv" argument's type.
if (const Symbol *inScope{scope.FindSymbol(derived.name())}) {
const Symbol &ultimate{inScope->GetUltimate()};
DerivedTypeSpec localDerivedType{inScope->name(), ultimate};
if (ultimate.has<DerivedTypeDetails>() &&
evaluate::DynamicType{derived, /*isPolymorphic=*/false}
.IsTkCompatibleWith(evaluate::DynamicType{
localDerivedType, /*iP=*/false})) {
derivedScope = ultimate.scope();
const Symbol *localDerived{&inScope->GetUltimate()};
if (const auto *generic{
localDerived->detailsIf<GenericDetails>()}) {
localDerived = generic->derivedType();
}
if (localDerived && localDerived->has<DerivedTypeDetails>()) {
DerivedTypeSpec localDerivedType{
inScope->name(), *localDerived};
if (evaluate::DynamicType{derived, /*isPolymorphic=*/false}
.IsTkCompatibleWith(evaluate::DynamicType{
localDerivedType, /*iP=*/false})) {
derivedScope = localDerived->scope();
}
}
}
}
Expand Down
28 changes: 28 additions & 0 deletions flang/test/Lower/bug173766.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
!RUN: bbc -emit-fir -o - %s 2>&1 | FileCheck %s
module m
type samename
sequence
integer n
end type
interface samename
end interface
interface write(formatted)
module procedure :: write_formatted
end interface
contains
subroutine write_formatted(t, unit, iotype, v_list, iostat, iomsg)
type(samename), intent(in) :: t
integer, intent(in) :: unit
character(len=*), intent(in) :: iotype
integer, intent(in) :: v_list(:)
integer, intent(out) :: iostat
character(len=*), intent(inout) :: iomsg
end
subroutine test
print *, samename(123)
end
end

!CHECK: %[[VAL_8:.*]] = fir.address_of(@_QQMmFtest.nonTbpDefinedIoTable) : !fir.ref<tuple<i64, !fir.ref<!fir.array<1xtuple<!fir.ref<none>, !fir.ref<none>, i32, i8>>>, i1>>
!CHECK: %[[VAL_9:.*]] = fir.convert %[[VAL_8]] : (!fir.ref<tuple<i64, !fir.ref<!fir.array<1xtuple<!fir.ref<none>, !fir.ref<none>, i32, i8>>>, i1>>) -> !fir.ref<none>
!CHECK: %{{.*}} = fir.call @_FortranAioOutputDerivedType(%{{.*}}, %{{.*}}, %[[VAL_9]]) fastmath<contract> : (!fir.ref<i8>, !fir.box<none>, !fir.ref<none>) -> i1