Skip to content

Conversation

@dutkalex
Copy link

This PR fixes a configuration bug (#173810) that was particularly painful to track down because it happens in the compiler-rt builtins configuration, which is performed on the fly in the middle of the build step.

The symptoms
On recent macos systems, the old i386 arch is disabled even if the system SDK lists it as supported. However, while all the other subprojects correctly diagnose the situation and adequately remove i386 from the list of architectures to compile for, the builtins behave differently and fails to build.

The root cause
When configuring the builtins the variable TEST_COMPILE_ONLY is ON (see. https://github.com/llvm/llvm-project/blob/main/compiler-rt/cmake/builtin-config-ix.cmake#L219), and because the cmake code performing this logic is located in an if(NOT TEST_COMPILE_ONLY) block, the code is not executed in this specific context.

The proposed solution
Move this piece of logic outside of the conditional block so that all code paths are treated equally.

@github-actions
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants