Skip to content

[OpenMP][NFC] Refactor Non-contiguous Update Tests#190923

Merged
amitamd7 merged 1 commit intollvm:mainfrom
amitamd7:tiwari_non-contiguous_update_refactor
Apr 10, 2026
Merged

[OpenMP][NFC] Refactor Non-contiguous Update Tests#190923
amitamd7 merged 1 commit intollvm:mainfrom
amitamd7:tiwari_non-contiguous_update_refactor

Conversation

@amitamd7
Copy link
Copy Markdown
Contributor

@amitamd7 amitamd7 commented Apr 8, 2026

The PR refactors the non-contiguous update tests as raised as a TODO in one of the comments in the related PR. Prefixed all with strided_update. For offload tests, added a dedicated sub-directory.

@llvmbot llvmbot added clang:openmp OpenMP related changes to Clang offload labels Apr 8, 2026
@llvmbot
Copy link
Copy Markdown
Member

llvmbot commented Apr 8, 2026

@llvm/pr-subscribers-offload

Author: Amit Tiwari (amitamd7)

Changes

The PR re-organizes, renames the non-contiguous update tests as raised as a TODO in one of the comments in the related PR.


Full diff: https://github.com/llvm/llvm-project/pull/190923.diff

62 Files Affected:

  • (renamed) clang/test/OpenMP/strided_update_messages_from.c ()
  • (renamed) clang/test/OpenMP/strided_update_messages_to.c ()
  • (renamed) clang/test/OpenMP/strided_update_multiple_messages_from.c ()
  • (renamed) clang/test/OpenMP/strided_update_multiple_messages_to.c ()
  • (renamed) clang/test/OpenMP/strided_update_partial_messages_from.c ()
  • (renamed) clang/test/OpenMP/strided_update_partial_messages_to.c ()
  • (renamed) clang/test/OpenMP/strided_update_ptr_messages_from.c ()
  • (renamed) clang/test/OpenMP/strided_update_ptr_messages_to.c ()
  • (renamed) clang/test/OpenMP/strided_update_ptr_multiple_messages_from.c ()
  • (renamed) clang/test/OpenMP/strided_update_ptr_multiple_messages_to.c ()
  • (renamed) clang/test/OpenMP/strided_update_ptr_partial_messages_from.c ()
  • (renamed) clang/test/OpenMP/strided_update_ptr_partial_messages_to.c ()
  • (renamed) clang/test/OpenMP/strided_update_ptr_variable_count_and_stride_messages.c ()
  • (renamed) clang/test/OpenMP/strided_update_ptr_variable_count_messages.c ()
  • (renamed) clang/test/OpenMP/strided_update_ptr_variable_stride_messages.c ()
  • (renamed) clang/test/OpenMP/strided_update_struct_messages_from.c ()
  • (renamed) clang/test/OpenMP/strided_update_struct_messages_to.c ()
  • (renamed) clang/test/OpenMP/strided_update_struct_multiple_messages_from.c ()
  • (renamed) clang/test/OpenMP/strided_update_struct_multiple_messages_to.c ()
  • (renamed) clang/test/OpenMP/strided_update_struct_partial_messages_from.c ()
  • (renamed) clang/test/OpenMP/strided_update_struct_partial_messages_to.c ()
  • (renamed) clang/test/OpenMP/strided_update_struct_ptr_messages_from.c ()
  • (renamed) clang/test/OpenMP/strided_update_struct_ptr_messages_to.c ()
  • (renamed) clang/test/OpenMP/strided_update_struct_ptr_multiple_messages_from.c ()
  • (renamed) clang/test/OpenMP/strided_update_struct_ptr_multiple_messages_to.c ()
  • (renamed) clang/test/OpenMP/strided_update_struct_ptr_partial_messages_from.c ()
  • (renamed) clang/test/OpenMP/strided_update_struct_ptr_partial_messages_to.c ()
  • (renamed) clang/test/OpenMP/strided_update_struct_variable_count_and_stride_messages.c ()
  • (renamed) clang/test/OpenMP/strided_update_variable_count_and_stride_messages.c ()
  • (renamed) clang/test/OpenMP/strided_update_variable_stride_codegen.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_count_expression.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_count_expression_complex.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_from.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_from_pointer.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_multidim_offset.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_multiple_arrays_count_expression.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_multiple_arrays_variable_stride.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_multiple_from.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_multiple_to.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_partial_from.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_partial_to.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_ptr_count_expression.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_ptr_multiple_from.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_ptr_multiple_to.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_ptr_partial_from.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_ptr_partial_to.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_ptr_variable_count_and_stride.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_ptr_variable_stride.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_struct_count_expression.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_struct_from.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_struct_multiple_from.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_struct_multiple_to.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_struct_partial_from.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_struct_partial_to.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_struct_to.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_struct_variable_count_and_stride.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_struct_variable_stride.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_to.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_to_pointer.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_variable_count_and_stride.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_variable_stride.c ()
  • (renamed) offload/test/offloading/strided_update/strided_update_variable_stride_misc.c ()
diff --git a/clang/test/OpenMP/target_update_strided_messages_from.c b/clang/test/OpenMP/strided_update_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_messages_from.c
rename to clang/test/OpenMP/strided_update_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_messages_to.c b/clang/test/OpenMP/strided_update_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_messages_to.c
rename to clang/test/OpenMP/strided_update_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_multiple_messages_from.c b/clang/test/OpenMP/strided_update_multiple_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_multiple_messages_from.c
rename to clang/test/OpenMP/strided_update_multiple_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_multiple_messages_to.c b/clang/test/OpenMP/strided_update_multiple_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_multiple_messages_to.c
rename to clang/test/OpenMP/strided_update_multiple_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_partial_messages_from.c b/clang/test/OpenMP/strided_update_partial_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_partial_messages_from.c
rename to clang/test/OpenMP/strided_update_partial_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_partial_messages_to.c b/clang/test/OpenMP/strided_update_partial_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_partial_messages_to.c
rename to clang/test/OpenMP/strided_update_partial_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_ptr_messages_from.c b/clang/test/OpenMP/strided_update_ptr_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_ptr_messages_from.c
rename to clang/test/OpenMP/strided_update_ptr_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_ptr_messages_to.c b/clang/test/OpenMP/strided_update_ptr_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_ptr_messages_to.c
rename to clang/test/OpenMP/strided_update_ptr_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_ptr_multiple_messages_from.c b/clang/test/OpenMP/strided_update_ptr_multiple_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_ptr_multiple_messages_from.c
rename to clang/test/OpenMP/strided_update_ptr_multiple_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_ptr_multiple_messages_to.c b/clang/test/OpenMP/strided_update_ptr_multiple_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_ptr_multiple_messages_to.c
rename to clang/test/OpenMP/strided_update_ptr_multiple_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_ptr_partial_messages_from.c b/clang/test/OpenMP/strided_update_ptr_partial_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_ptr_partial_messages_from.c
rename to clang/test/OpenMP/strided_update_ptr_partial_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_ptr_partial_messages_to.c b/clang/test/OpenMP/strided_update_ptr_partial_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_ptr_partial_messages_to.c
rename to clang/test/OpenMP/strided_update_ptr_partial_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_ptr_variable_count_and_stride_messages.c b/clang/test/OpenMP/strided_update_ptr_variable_count_and_stride_messages.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_ptr_variable_count_and_stride_messages.c
rename to clang/test/OpenMP/strided_update_ptr_variable_count_and_stride_messages.c
diff --git a/clang/test/OpenMP/target_update_strided_ptr_variable_count_messages.c b/clang/test/OpenMP/strided_update_ptr_variable_count_messages.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_ptr_variable_count_messages.c
rename to clang/test/OpenMP/strided_update_ptr_variable_count_messages.c
diff --git a/clang/test/OpenMP/target_update_strided_ptr_variable_stride_messages.c b/clang/test/OpenMP/strided_update_ptr_variable_stride_messages.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_ptr_variable_stride_messages.c
rename to clang/test/OpenMP/strided_update_ptr_variable_stride_messages.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_messages_from.c b/clang/test/OpenMP/strided_update_struct_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_messages_from.c
rename to clang/test/OpenMP/strided_update_struct_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_messages_to.c b/clang/test/OpenMP/strided_update_struct_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_messages_to.c
rename to clang/test/OpenMP/strided_update_struct_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_multiple_messages_from.c b/clang/test/OpenMP/strided_update_struct_multiple_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_multiple_messages_from.c
rename to clang/test/OpenMP/strided_update_struct_multiple_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_multiple_messages_to.c b/clang/test/OpenMP/strided_update_struct_multiple_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_multiple_messages_to.c
rename to clang/test/OpenMP/strided_update_struct_multiple_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_partial_messages_from.c b/clang/test/OpenMP/strided_update_struct_partial_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_partial_messages_from.c
rename to clang/test/OpenMP/strided_update_struct_partial_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_partial_messages_to.c b/clang/test/OpenMP/strided_update_struct_partial_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_partial_messages_to.c
rename to clang/test/OpenMP/strided_update_struct_partial_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_ptr_messages_from.c b/clang/test/OpenMP/strided_update_struct_ptr_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_ptr_messages_from.c
rename to clang/test/OpenMP/strided_update_struct_ptr_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_ptr_messages_to.c b/clang/test/OpenMP/strided_update_struct_ptr_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_ptr_messages_to.c
rename to clang/test/OpenMP/strided_update_struct_ptr_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_ptr_multiple_messages_from.c b/clang/test/OpenMP/strided_update_struct_ptr_multiple_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_ptr_multiple_messages_from.c
rename to clang/test/OpenMP/strided_update_struct_ptr_multiple_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_ptr_multiple_messages_to.c b/clang/test/OpenMP/strided_update_struct_ptr_multiple_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_ptr_multiple_messages_to.c
rename to clang/test/OpenMP/strided_update_struct_ptr_multiple_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_ptr_partial_messages_from.c b/clang/test/OpenMP/strided_update_struct_ptr_partial_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_ptr_partial_messages_from.c
rename to clang/test/OpenMP/strided_update_struct_ptr_partial_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_ptr_partial_messages_to.c b/clang/test/OpenMP/strided_update_struct_ptr_partial_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_ptr_partial_messages_to.c
rename to clang/test/OpenMP/strided_update_struct_ptr_partial_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_variable_count_and_stride_messages.c b/clang/test/OpenMP/strided_update_struct_variable_count_and_stride_messages.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_variable_count_and_stride_messages.c
rename to clang/test/OpenMP/strided_update_struct_variable_count_and_stride_messages.c
diff --git a/clang/test/OpenMP/target_update_variable_count_and_stride_messages.c b/clang/test/OpenMP/strided_update_variable_count_and_stride_messages.c
similarity index 100%
rename from clang/test/OpenMP/target_update_variable_count_and_stride_messages.c
rename to clang/test/OpenMP/strided_update_variable_count_and_stride_messages.c
diff --git a/clang/test/OpenMP/target_update_variable_stride_codegen.c b/clang/test/OpenMP/strided_update_variable_stride_codegen.c
similarity index 100%
rename from clang/test/OpenMP/target_update_variable_stride_codegen.c
rename to clang/test/OpenMP/strided_update_variable_stride_codegen.c
diff --git a/offload/test/offloading/strided_update_count_expression.c b/offload/test/offloading/strided_update/strided_update_count_expression.c
similarity index 100%
rename from offload/test/offloading/strided_update_count_expression.c
rename to offload/test/offloading/strided_update/strided_update_count_expression.c
diff --git a/offload/test/offloading/strided_update_count_expression_complex.c b/offload/test/offloading/strided_update/strided_update_count_expression_complex.c
similarity index 100%
rename from offload/test/offloading/strided_update_count_expression_complex.c
rename to offload/test/offloading/strided_update/strided_update_count_expression_complex.c
diff --git a/offload/test/offloading/strided_update_from.c b/offload/test/offloading/strided_update/strided_update_from.c
similarity index 100%
rename from offload/test/offloading/strided_update_from.c
rename to offload/test/offloading/strided_update/strided_update_from.c
diff --git a/offload/test/offloading/target_update_from.c b/offload/test/offloading/strided_update/strided_update_from_pointer.c
similarity index 100%
rename from offload/test/offloading/target_update_from.c
rename to offload/test/offloading/strided_update/strided_update_from_pointer.c
diff --git a/offload/test/offloading/strided_offset_multidim_update.c b/offload/test/offloading/strided_update/strided_update_multidim_offset.c
similarity index 100%
rename from offload/test/offloading/strided_offset_multidim_update.c
rename to offload/test/offloading/strided_update/strided_update_multidim_offset.c
diff --git a/offload/test/offloading/strided_update_multiple_arrays_count_expression.c b/offload/test/offloading/strided_update/strided_update_multiple_arrays_count_expression.c
similarity index 100%
rename from offload/test/offloading/strided_update_multiple_arrays_count_expression.c
rename to offload/test/offloading/strided_update/strided_update_multiple_arrays_count_expression.c
diff --git a/offload/test/offloading/strided_update_multiple_arrays_variable_stride.c b/offload/test/offloading/strided_update/strided_update_multiple_arrays_variable_stride.c
similarity index 100%
rename from offload/test/offloading/strided_update_multiple_arrays_variable_stride.c
rename to offload/test/offloading/strided_update/strided_update_multiple_arrays_variable_stride.c
diff --git a/offload/test/offloading/strided_multiple_update_from.c b/offload/test/offloading/strided_update/strided_update_multiple_from.c
similarity index 100%
rename from offload/test/offloading/strided_multiple_update_from.c
rename to offload/test/offloading/strided_update/strided_update_multiple_from.c
diff --git a/offload/test/offloading/strided_multiple_update_to.c b/offload/test/offloading/strided_update/strided_update_multiple_to.c
similarity index 100%
rename from offload/test/offloading/strided_multiple_update_to.c
rename to offload/test/offloading/strided_update/strided_update_multiple_to.c
diff --git a/offload/test/offloading/strided_partial_update_from.c b/offload/test/offloading/strided_update/strided_update_partial_from.c
similarity index 100%
rename from offload/test/offloading/strided_partial_update_from.c
rename to offload/test/offloading/strided_update/strided_update_partial_from.c
diff --git a/offload/test/offloading/strided_partial_update_to.c b/offload/test/offloading/strided_update/strided_update_partial_to.c
similarity index 100%
rename from offload/test/offloading/strided_partial_update_to.c
rename to offload/test/offloading/strided_update/strided_update_partial_to.c
diff --git a/offload/test/offloading/target_update_ptr_count_expression.c b/offload/test/offloading/strided_update/strided_update_ptr_count_expression.c
similarity index 100%
rename from offload/test/offloading/target_update_ptr_count_expression.c
rename to offload/test/offloading/strided_update/strided_update_ptr_count_expression.c
diff --git a/offload/test/offloading/strided_ptr_multiple_update_from.c b/offload/test/offloading/strided_update/strided_update_ptr_multiple_from.c
similarity index 100%
rename from offload/test/offloading/strided_ptr_multiple_update_from.c
rename to offload/test/offloading/strided_update/strided_update_ptr_multiple_from.c
diff --git a/offload/test/offloading/strided_ptr_multiple_update_to.c b/offload/test/offloading/strided_update/strided_update_ptr_multiple_to.c
similarity index 100%
rename from offload/test/offloading/strided_ptr_multiple_update_to.c
rename to offload/test/offloading/strided_update/strided_update_ptr_multiple_to.c
diff --git a/offload/test/offloading/strided_ptr_partial_update_from.c b/offload/test/offloading/strided_update/strided_update_ptr_partial_from.c
similarity index 100%
rename from offload/test/offloading/strided_ptr_partial_update_from.c
rename to offload/test/offloading/strided_update/strided_update_ptr_partial_from.c
diff --git a/offload/test/offloading/strided_ptr_partial_update_to.c b/offload/test/offloading/strided_update/strided_update_ptr_partial_to.c
similarity index 100%
rename from offload/test/offloading/strided_ptr_partial_update_to.c
rename to offload/test/offloading/strided_update/strided_update_ptr_partial_to.c
diff --git a/offload/test/offloading/target_update_ptr_variable_count_and_stride.c b/offload/test/offloading/strided_update/strided_update_ptr_variable_count_and_stride.c
similarity index 100%
rename from offload/test/offloading/target_update_ptr_variable_count_and_stride.c
rename to offload/test/offloading/strided_update/strided_update_ptr_variable_count_and_stride.c
diff --git a/offload/test/offloading/target_update_ptr_variable_stride.c b/offload/test/offloading/strided_update/strided_update_ptr_variable_stride.c
similarity index 100%
rename from offload/test/offloading/target_update_ptr_variable_stride.c
rename to offload/test/offloading/strided_update/strided_update_ptr_variable_stride.c
diff --git a/offload/test/offloading/target_update_strided_struct_count_expression.c b/offload/test/offloading/strided_update/strided_update_struct_count_expression.c
similarity index 100%
rename from offload/test/offloading/target_update_strided_struct_count_expression.c
rename to offload/test/offloading/strided_update/strided_update_struct_count_expression.c
diff --git a/offload/test/offloading/target_update_strided_struct_from.c b/offload/test/offloading/strided_update/strided_update_struct_from.c
similarity index 100%
rename from offload/test/offloading/target_update_strided_struct_from.c
rename to offload/test/offloading/strided_update/strided_update_struct_from.c
diff --git a/offload/test/offloading/target_update_strided_struct_multiple_from.c b/offload/test/offloading/strided_update/strided_update_struct_multiple_from.c
similarity index 100%
rename from offload/test/offloading/target_update_strided_struct_multiple_from.c
rename to offload/test/offloading/strided_update/strided_update_struct_multiple_from.c
diff --git a/offload/test/offloading/target_update_strided_struct_multiple_to.c b/offload/test/offloading/strided_update/strided_update_struct_multiple_to.c
similarity index 100%
rename from offload/test/offloading/target_update_strided_struct_multiple_to.c
rename to offload/test/offloading/strided_update/strided_update_struct_multiple_to.c
diff --git a/offload/test/offloading/target_update_strided_struct_partial_from.c b/offload/test/offloading/strided_update/strided_update_struct_partial_from.c
similarity index 100%
rename from offload/test/offloading/target_update_strided_struct_partial_from.c
rename to offload/test/offloading/strided_update/strided_update_struct_partial_from.c
diff --git a/offload/test/offloading/target_update_strided_struct_partial_to.c b/offload/test/offloading/strided_update/strided_update_struct_partial_to.c
similarity index 100%
rename from offload/test/offloading/target_update_strided_struct_partial_to.c
rename to offload/test/offloading/strided_update/strided_update_struct_partial_to.c
diff --git a/offload/test/offloading/target_update_strided_struct_to.c b/offload/test/offloading/strided_update/strided_update_struct_to.c
similarity index 100%
rename from offload/test/offloading/target_update_strided_struct_to.c
rename to offload/test/offloading/strided_update/strided_update_struct_to.c
diff --git a/offload/test/offloading/target_update_strided_struct_variable_count_and_stride.c b/offload/test/offloading/strided_update/strided_update_struct_variable_count_and_stride.c
similarity index 100%
rename from offload/test/offloading/target_update_strided_struct_variable_count_and_stride.c
rename to offload/test/offloading/strided_update/strided_update_struct_variable_count_and_stride.c
diff --git a/offload/test/offloading/target_update_strided_struct_variable_stride.c b/offload/test/offloading/strided_update/strided_update_struct_variable_stride.c
similarity index 100%
rename from offload/test/offloading/target_update_strided_struct_variable_stride.c
rename to offload/test/offloading/strided_update/strided_update_struct_variable_stride.c
diff --git a/offload/test/offloading/strided_update_to.c b/offload/test/offloading/strided_update/strided_update_to.c
similarity index 100%
rename from offload/test/offloading/strided_update_to.c
rename to offload/test/offloading/strided_update/strided_update_to.c
diff --git a/offload/test/offloading/target_update_to.c b/offload/test/offloading/strided_update/strided_update_to_pointer.c
similarity index 100%
rename from offload/test/offloading/target_update_to.c
rename to offload/test/offloading/strided_update/strided_update_to_pointer.c
diff --git a/offload/test/offloading/strided_update_variable_count_and_stride.c b/offload/test/offloading/strided_update/strided_update_variable_count_and_stride.c
similarity index 100%
rename from offload/test/offloading/strided_update_variable_count_and_stride.c
rename to offload/test/offloading/strided_update/strided_update_variable_count_and_stride.c
diff --git a/offload/test/offloading/strided_update_variable_stride.c b/offload/test/offloading/strided_update/strided_update_variable_stride.c
similarity index 100%
rename from offload/test/offloading/strided_update_variable_stride.c
rename to offload/test/offloading/strided_update/strided_update_variable_stride.c
diff --git a/offload/test/offloading/strided_update_variable_stride_misc.c b/offload/test/offloading/strided_update/strided_update_variable_stride_misc.c
similarity index 100%
rename from offload/test/offloading/strided_update_variable_stride_misc.c
rename to offload/test/offloading/strided_update/strided_update_variable_stride_misc.c

@amitamd7 amitamd7 requested a review from abhinavgaba April 8, 2026 15:52
Copy link
Copy Markdown
Contributor

@abhinavgaba abhinavgaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up!

@amitamd7 amitamd7 merged commit 7459e10 into llvm:main Apr 10, 2026
13 checks passed
@llvm-ci
Copy link
Copy Markdown

llvm-ci commented Apr 10, 2026

LLVM Buildbot has detected a new failure on builder lldb-aarch64-windows running on linaro-armv8-windows-msvc-05 while building clang,offload at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/17192

Here is the relevant piece of the build log for the reference
Step 6 (test) failure: build (failure)
...
PASS: lldb-api :: functionalities/breakpoint/breakpoint_names/TestBreakpointNames.py (332 of 2508)
PASS: lldb-api :: functionalities/breakpoint/breakpoint_conditions/TestBreakpointConditions.py (333 of 2508)
PASS: lldb-api :: functionalities/breakpoint/breakpoint_on_overload/TestBreakOnOverload.py (334 of 2508)
PASS: lldb-api :: functionalities/breakpoint/breakpoint_options/TestBreakpointOptions.py (335 of 2508)
PASS: lldb-api :: functionalities/breakpoint/breakpoint_reset_upon_run/TestBreakpointResetUponRun.py (336 of 2508)
PASS: lldb-api :: functionalities/breakpoint/breakpoint_on_lambda_capture/TestBreakOnLambdaCapture.py (337 of 2508)
PASS: lldb-api :: functionalities/breakpoint/breakpoint_set_restart/TestBreakpointSetRestart.py (338 of 2508)
UNSUPPORTED: lldb-api :: functionalities/breakpoint/breakpoint_with_realpath_and_source_map/TestBreakpoint.py (339 of 2508)
UNSUPPORTED: lldb-api :: functionalities/breakpoint/comp_dir_symlink/TestCompDirSymLink.py (340 of 2508)
PASS: lldb-api :: functionalities/breakpoint/callback_deletes_breakpoints/TestCallbackDeletesBreakpoints.py (341 of 2508)
FAIL: lldb-api :: functionalities/breakpoint/consecutive_breakpoints/TestConsecutiveBreakpoints.py (342 of 2508)
******************** TEST 'lldb-api :: functionalities/breakpoint/consecutive_breakpoints/TestConsecutiveBreakpoints.py' FAILED ********************
Script:
--
C:/Users/tcwg/scoop/apps/python/current/python.exe C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/llvm-project/lldb\test\API\dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./lib --env LLVM_INCLUDE_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/include --env LLVM_TOOLS_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin --arch aarch64 --build-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex --lldb-module-cache-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex/module-cache-lldb\lldb-api --clang-module-cache-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex/module-cache-clang\lldb-api --executable C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/lldb.exe --compiler C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/clang.exe --dsymutil C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/dsymutil.exe --make C:/Users/tcwg/scoop/shims/make.exe --llvm-tools-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin --lldb-obj-root C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/tools/lldb --lldb-libs-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./lib --cmake-build-type Release --skip-category=watchpoint C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\functionalities\breakpoint\consecutive_breakpoints -p TestConsecutiveBreakpoints.py
--
Exit Code: 1

Command Output (stdout):
--
lldb version 23.0.0git (https://github.com/llvm/llvm-project.git revision 7459e10f34aa86952b1620d0cb48b40be112ebe9)
  clang revision 7459e10f34aa86952b1620d0cb48b40be112ebe9
  llvm revision 7459e10f34aa86952b1620d0cb48b40be112ebe9
Skipping the following test categories: watchpoint, libc++, libstdcxx, dwo, dsym, gmodules, debugserver, objc, fork, pexpect


--
Command Output (stderr):
--
PASS: LLDB (C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe-aarch64) :: test_continue (TestConsecutiveBreakpoints.ConsecutiveBreakpointsTestCase.test_continue)

FAIL: LLDB (C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe-aarch64) :: test_single_step (TestConsecutiveBreakpoints.ConsecutiveBreakpointsTestCase.test_single_step)

Log Files:

 - C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\lldb-test-build.noindex\functionalities\breakpoint\consecutive_breakpoints\TestConsecutiveBreakpoints\Failure_test_single_step.log

PASS: LLDB (C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe-aarch64) :: test_single_step_thread_specific (TestConsecutiveBreakpoints.ConsecutiveBreakpointsTestCase.test_single_step_thread_specific)

======================================================================

FAIL: test_single_step (TestConsecutiveBreakpoints.ConsecutiveBreakpointsTestCase.test_single_step)

   Test that single step stops at the second breakpoint.

----------------------------------------------------------------------

Traceback (most recent call last):


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:openmp OpenMP related changes to Clang offload

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants