[OpenMP][NFC] Refactor Non-contiguous Update Tests#190923
Merged
Conversation
Member
|
@llvm/pr-subscribers-offload Author: Amit Tiwari (amitamd7) ChangesThe PR re-organizes, renames the non-contiguous update tests as raised as a TODO in one of the comments in the related PR. Full diff: https://github.com/llvm/llvm-project/pull/190923.diff 62 Files Affected:
diff --git a/clang/test/OpenMP/target_update_strided_messages_from.c b/clang/test/OpenMP/strided_update_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_messages_from.c
rename to clang/test/OpenMP/strided_update_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_messages_to.c b/clang/test/OpenMP/strided_update_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_messages_to.c
rename to clang/test/OpenMP/strided_update_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_multiple_messages_from.c b/clang/test/OpenMP/strided_update_multiple_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_multiple_messages_from.c
rename to clang/test/OpenMP/strided_update_multiple_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_multiple_messages_to.c b/clang/test/OpenMP/strided_update_multiple_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_multiple_messages_to.c
rename to clang/test/OpenMP/strided_update_multiple_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_partial_messages_from.c b/clang/test/OpenMP/strided_update_partial_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_partial_messages_from.c
rename to clang/test/OpenMP/strided_update_partial_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_partial_messages_to.c b/clang/test/OpenMP/strided_update_partial_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_partial_messages_to.c
rename to clang/test/OpenMP/strided_update_partial_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_ptr_messages_from.c b/clang/test/OpenMP/strided_update_ptr_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_ptr_messages_from.c
rename to clang/test/OpenMP/strided_update_ptr_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_ptr_messages_to.c b/clang/test/OpenMP/strided_update_ptr_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_ptr_messages_to.c
rename to clang/test/OpenMP/strided_update_ptr_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_ptr_multiple_messages_from.c b/clang/test/OpenMP/strided_update_ptr_multiple_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_ptr_multiple_messages_from.c
rename to clang/test/OpenMP/strided_update_ptr_multiple_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_ptr_multiple_messages_to.c b/clang/test/OpenMP/strided_update_ptr_multiple_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_ptr_multiple_messages_to.c
rename to clang/test/OpenMP/strided_update_ptr_multiple_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_ptr_partial_messages_from.c b/clang/test/OpenMP/strided_update_ptr_partial_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_ptr_partial_messages_from.c
rename to clang/test/OpenMP/strided_update_ptr_partial_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_ptr_partial_messages_to.c b/clang/test/OpenMP/strided_update_ptr_partial_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_ptr_partial_messages_to.c
rename to clang/test/OpenMP/strided_update_ptr_partial_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_ptr_variable_count_and_stride_messages.c b/clang/test/OpenMP/strided_update_ptr_variable_count_and_stride_messages.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_ptr_variable_count_and_stride_messages.c
rename to clang/test/OpenMP/strided_update_ptr_variable_count_and_stride_messages.c
diff --git a/clang/test/OpenMP/target_update_strided_ptr_variable_count_messages.c b/clang/test/OpenMP/strided_update_ptr_variable_count_messages.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_ptr_variable_count_messages.c
rename to clang/test/OpenMP/strided_update_ptr_variable_count_messages.c
diff --git a/clang/test/OpenMP/target_update_strided_ptr_variable_stride_messages.c b/clang/test/OpenMP/strided_update_ptr_variable_stride_messages.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_ptr_variable_stride_messages.c
rename to clang/test/OpenMP/strided_update_ptr_variable_stride_messages.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_messages_from.c b/clang/test/OpenMP/strided_update_struct_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_messages_from.c
rename to clang/test/OpenMP/strided_update_struct_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_messages_to.c b/clang/test/OpenMP/strided_update_struct_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_messages_to.c
rename to clang/test/OpenMP/strided_update_struct_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_multiple_messages_from.c b/clang/test/OpenMP/strided_update_struct_multiple_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_multiple_messages_from.c
rename to clang/test/OpenMP/strided_update_struct_multiple_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_multiple_messages_to.c b/clang/test/OpenMP/strided_update_struct_multiple_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_multiple_messages_to.c
rename to clang/test/OpenMP/strided_update_struct_multiple_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_partial_messages_from.c b/clang/test/OpenMP/strided_update_struct_partial_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_partial_messages_from.c
rename to clang/test/OpenMP/strided_update_struct_partial_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_partial_messages_to.c b/clang/test/OpenMP/strided_update_struct_partial_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_partial_messages_to.c
rename to clang/test/OpenMP/strided_update_struct_partial_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_ptr_messages_from.c b/clang/test/OpenMP/strided_update_struct_ptr_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_ptr_messages_from.c
rename to clang/test/OpenMP/strided_update_struct_ptr_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_ptr_messages_to.c b/clang/test/OpenMP/strided_update_struct_ptr_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_ptr_messages_to.c
rename to clang/test/OpenMP/strided_update_struct_ptr_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_ptr_multiple_messages_from.c b/clang/test/OpenMP/strided_update_struct_ptr_multiple_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_ptr_multiple_messages_from.c
rename to clang/test/OpenMP/strided_update_struct_ptr_multiple_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_ptr_multiple_messages_to.c b/clang/test/OpenMP/strided_update_struct_ptr_multiple_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_ptr_multiple_messages_to.c
rename to clang/test/OpenMP/strided_update_struct_ptr_multiple_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_ptr_partial_messages_from.c b/clang/test/OpenMP/strided_update_struct_ptr_partial_messages_from.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_ptr_partial_messages_from.c
rename to clang/test/OpenMP/strided_update_struct_ptr_partial_messages_from.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_ptr_partial_messages_to.c b/clang/test/OpenMP/strided_update_struct_ptr_partial_messages_to.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_ptr_partial_messages_to.c
rename to clang/test/OpenMP/strided_update_struct_ptr_partial_messages_to.c
diff --git a/clang/test/OpenMP/target_update_strided_struct_variable_count_and_stride_messages.c b/clang/test/OpenMP/strided_update_struct_variable_count_and_stride_messages.c
similarity index 100%
rename from clang/test/OpenMP/target_update_strided_struct_variable_count_and_stride_messages.c
rename to clang/test/OpenMP/strided_update_struct_variable_count_and_stride_messages.c
diff --git a/clang/test/OpenMP/target_update_variable_count_and_stride_messages.c b/clang/test/OpenMP/strided_update_variable_count_and_stride_messages.c
similarity index 100%
rename from clang/test/OpenMP/target_update_variable_count_and_stride_messages.c
rename to clang/test/OpenMP/strided_update_variable_count_and_stride_messages.c
diff --git a/clang/test/OpenMP/target_update_variable_stride_codegen.c b/clang/test/OpenMP/strided_update_variable_stride_codegen.c
similarity index 100%
rename from clang/test/OpenMP/target_update_variable_stride_codegen.c
rename to clang/test/OpenMP/strided_update_variable_stride_codegen.c
diff --git a/offload/test/offloading/strided_update_count_expression.c b/offload/test/offloading/strided_update/strided_update_count_expression.c
similarity index 100%
rename from offload/test/offloading/strided_update_count_expression.c
rename to offload/test/offloading/strided_update/strided_update_count_expression.c
diff --git a/offload/test/offloading/strided_update_count_expression_complex.c b/offload/test/offloading/strided_update/strided_update_count_expression_complex.c
similarity index 100%
rename from offload/test/offloading/strided_update_count_expression_complex.c
rename to offload/test/offloading/strided_update/strided_update_count_expression_complex.c
diff --git a/offload/test/offloading/strided_update_from.c b/offload/test/offloading/strided_update/strided_update_from.c
similarity index 100%
rename from offload/test/offloading/strided_update_from.c
rename to offload/test/offloading/strided_update/strided_update_from.c
diff --git a/offload/test/offloading/target_update_from.c b/offload/test/offloading/strided_update/strided_update_from_pointer.c
similarity index 100%
rename from offload/test/offloading/target_update_from.c
rename to offload/test/offloading/strided_update/strided_update_from_pointer.c
diff --git a/offload/test/offloading/strided_offset_multidim_update.c b/offload/test/offloading/strided_update/strided_update_multidim_offset.c
similarity index 100%
rename from offload/test/offloading/strided_offset_multidim_update.c
rename to offload/test/offloading/strided_update/strided_update_multidim_offset.c
diff --git a/offload/test/offloading/strided_update_multiple_arrays_count_expression.c b/offload/test/offloading/strided_update/strided_update_multiple_arrays_count_expression.c
similarity index 100%
rename from offload/test/offloading/strided_update_multiple_arrays_count_expression.c
rename to offload/test/offloading/strided_update/strided_update_multiple_arrays_count_expression.c
diff --git a/offload/test/offloading/strided_update_multiple_arrays_variable_stride.c b/offload/test/offloading/strided_update/strided_update_multiple_arrays_variable_stride.c
similarity index 100%
rename from offload/test/offloading/strided_update_multiple_arrays_variable_stride.c
rename to offload/test/offloading/strided_update/strided_update_multiple_arrays_variable_stride.c
diff --git a/offload/test/offloading/strided_multiple_update_from.c b/offload/test/offloading/strided_update/strided_update_multiple_from.c
similarity index 100%
rename from offload/test/offloading/strided_multiple_update_from.c
rename to offload/test/offloading/strided_update/strided_update_multiple_from.c
diff --git a/offload/test/offloading/strided_multiple_update_to.c b/offload/test/offloading/strided_update/strided_update_multiple_to.c
similarity index 100%
rename from offload/test/offloading/strided_multiple_update_to.c
rename to offload/test/offloading/strided_update/strided_update_multiple_to.c
diff --git a/offload/test/offloading/strided_partial_update_from.c b/offload/test/offloading/strided_update/strided_update_partial_from.c
similarity index 100%
rename from offload/test/offloading/strided_partial_update_from.c
rename to offload/test/offloading/strided_update/strided_update_partial_from.c
diff --git a/offload/test/offloading/strided_partial_update_to.c b/offload/test/offloading/strided_update/strided_update_partial_to.c
similarity index 100%
rename from offload/test/offloading/strided_partial_update_to.c
rename to offload/test/offloading/strided_update/strided_update_partial_to.c
diff --git a/offload/test/offloading/target_update_ptr_count_expression.c b/offload/test/offloading/strided_update/strided_update_ptr_count_expression.c
similarity index 100%
rename from offload/test/offloading/target_update_ptr_count_expression.c
rename to offload/test/offloading/strided_update/strided_update_ptr_count_expression.c
diff --git a/offload/test/offloading/strided_ptr_multiple_update_from.c b/offload/test/offloading/strided_update/strided_update_ptr_multiple_from.c
similarity index 100%
rename from offload/test/offloading/strided_ptr_multiple_update_from.c
rename to offload/test/offloading/strided_update/strided_update_ptr_multiple_from.c
diff --git a/offload/test/offloading/strided_ptr_multiple_update_to.c b/offload/test/offloading/strided_update/strided_update_ptr_multiple_to.c
similarity index 100%
rename from offload/test/offloading/strided_ptr_multiple_update_to.c
rename to offload/test/offloading/strided_update/strided_update_ptr_multiple_to.c
diff --git a/offload/test/offloading/strided_ptr_partial_update_from.c b/offload/test/offloading/strided_update/strided_update_ptr_partial_from.c
similarity index 100%
rename from offload/test/offloading/strided_ptr_partial_update_from.c
rename to offload/test/offloading/strided_update/strided_update_ptr_partial_from.c
diff --git a/offload/test/offloading/strided_ptr_partial_update_to.c b/offload/test/offloading/strided_update/strided_update_ptr_partial_to.c
similarity index 100%
rename from offload/test/offloading/strided_ptr_partial_update_to.c
rename to offload/test/offloading/strided_update/strided_update_ptr_partial_to.c
diff --git a/offload/test/offloading/target_update_ptr_variable_count_and_stride.c b/offload/test/offloading/strided_update/strided_update_ptr_variable_count_and_stride.c
similarity index 100%
rename from offload/test/offloading/target_update_ptr_variable_count_and_stride.c
rename to offload/test/offloading/strided_update/strided_update_ptr_variable_count_and_stride.c
diff --git a/offload/test/offloading/target_update_ptr_variable_stride.c b/offload/test/offloading/strided_update/strided_update_ptr_variable_stride.c
similarity index 100%
rename from offload/test/offloading/target_update_ptr_variable_stride.c
rename to offload/test/offloading/strided_update/strided_update_ptr_variable_stride.c
diff --git a/offload/test/offloading/target_update_strided_struct_count_expression.c b/offload/test/offloading/strided_update/strided_update_struct_count_expression.c
similarity index 100%
rename from offload/test/offloading/target_update_strided_struct_count_expression.c
rename to offload/test/offloading/strided_update/strided_update_struct_count_expression.c
diff --git a/offload/test/offloading/target_update_strided_struct_from.c b/offload/test/offloading/strided_update/strided_update_struct_from.c
similarity index 100%
rename from offload/test/offloading/target_update_strided_struct_from.c
rename to offload/test/offloading/strided_update/strided_update_struct_from.c
diff --git a/offload/test/offloading/target_update_strided_struct_multiple_from.c b/offload/test/offloading/strided_update/strided_update_struct_multiple_from.c
similarity index 100%
rename from offload/test/offloading/target_update_strided_struct_multiple_from.c
rename to offload/test/offloading/strided_update/strided_update_struct_multiple_from.c
diff --git a/offload/test/offloading/target_update_strided_struct_multiple_to.c b/offload/test/offloading/strided_update/strided_update_struct_multiple_to.c
similarity index 100%
rename from offload/test/offloading/target_update_strided_struct_multiple_to.c
rename to offload/test/offloading/strided_update/strided_update_struct_multiple_to.c
diff --git a/offload/test/offloading/target_update_strided_struct_partial_from.c b/offload/test/offloading/strided_update/strided_update_struct_partial_from.c
similarity index 100%
rename from offload/test/offloading/target_update_strided_struct_partial_from.c
rename to offload/test/offloading/strided_update/strided_update_struct_partial_from.c
diff --git a/offload/test/offloading/target_update_strided_struct_partial_to.c b/offload/test/offloading/strided_update/strided_update_struct_partial_to.c
similarity index 100%
rename from offload/test/offloading/target_update_strided_struct_partial_to.c
rename to offload/test/offloading/strided_update/strided_update_struct_partial_to.c
diff --git a/offload/test/offloading/target_update_strided_struct_to.c b/offload/test/offloading/strided_update/strided_update_struct_to.c
similarity index 100%
rename from offload/test/offloading/target_update_strided_struct_to.c
rename to offload/test/offloading/strided_update/strided_update_struct_to.c
diff --git a/offload/test/offloading/target_update_strided_struct_variable_count_and_stride.c b/offload/test/offloading/strided_update/strided_update_struct_variable_count_and_stride.c
similarity index 100%
rename from offload/test/offloading/target_update_strided_struct_variable_count_and_stride.c
rename to offload/test/offloading/strided_update/strided_update_struct_variable_count_and_stride.c
diff --git a/offload/test/offloading/target_update_strided_struct_variable_stride.c b/offload/test/offloading/strided_update/strided_update_struct_variable_stride.c
similarity index 100%
rename from offload/test/offloading/target_update_strided_struct_variable_stride.c
rename to offload/test/offloading/strided_update/strided_update_struct_variable_stride.c
diff --git a/offload/test/offloading/strided_update_to.c b/offload/test/offloading/strided_update/strided_update_to.c
similarity index 100%
rename from offload/test/offloading/strided_update_to.c
rename to offload/test/offloading/strided_update/strided_update_to.c
diff --git a/offload/test/offloading/target_update_to.c b/offload/test/offloading/strided_update/strided_update_to_pointer.c
similarity index 100%
rename from offload/test/offloading/target_update_to.c
rename to offload/test/offloading/strided_update/strided_update_to_pointer.c
diff --git a/offload/test/offloading/strided_update_variable_count_and_stride.c b/offload/test/offloading/strided_update/strided_update_variable_count_and_stride.c
similarity index 100%
rename from offload/test/offloading/strided_update_variable_count_and_stride.c
rename to offload/test/offloading/strided_update/strided_update_variable_count_and_stride.c
diff --git a/offload/test/offloading/strided_update_variable_stride.c b/offload/test/offloading/strided_update/strided_update_variable_stride.c
similarity index 100%
rename from offload/test/offloading/strided_update_variable_stride.c
rename to offload/test/offloading/strided_update/strided_update_variable_stride.c
diff --git a/offload/test/offloading/strided_update_variable_stride_misc.c b/offload/test/offloading/strided_update/strided_update_variable_stride_misc.c
similarity index 100%
rename from offload/test/offloading/strided_update_variable_stride_misc.c
rename to offload/test/offloading/strided_update/strided_update_variable_stride_misc.c
|
abhinavgaba
approved these changes
Apr 9, 2026
Contributor
abhinavgaba
left a comment
There was a problem hiding this comment.
Thanks for the follow-up!
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/17192 Here is the relevant piece of the build log for the reference |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR refactors the non-contiguous update tests as raised as a TODO in one of the comments in the related PR. Prefixed all with
strided_update. For offload tests, added a dedicated sub-directory.