Skip to content

[libc][freebsd] skip exhaustive math tests in FreeBSD CI#199143

Merged
SchrodingerZhu merged 3 commits into
llvm:mainfrom
SchrodingerZhu:libc/freebsd-remove-expensive-tests
May 22, 2026
Merged

[libc][freebsd] skip exhaustive math tests in FreeBSD CI#199143
SchrodingerZhu merged 3 commits into
llvm:mainfrom
SchrodingerZhu:libc/freebsd-remove-expensive-tests

Conversation

@SchrodingerZhu
Copy link
Copy Markdown
Contributor

@SchrodingerZhu SchrodingerZhu commented May 22, 2026

Remove expensive tests to mitigate the long running time.

@llvmorg-github-actions
Copy link
Copy Markdown

@llvm/pr-subscribers-github-workflow

Author: Schrodinger ZHU Yifan (SchrodingerZhu)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/199143.diff

1 Files Affected:

  • (modified) .github/workflows/libc-freebsd-vm-tests.yml (+1-3)
diff --git a/.github/workflows/libc-freebsd-vm-tests.yml b/.github/workflows/libc-freebsd-vm-tests.yml
index 7f2d69c17c2c3..d4e5fe48033ec 100644
--- a/.github/workflows/libc-freebsd-vm-tests.yml
+++ b/.github/workflows/libc-freebsd-vm-tests.yml
@@ -30,7 +30,7 @@ jobs:
         run: |
           pkg update
           pkg upgrade -y
-          pkg install -y mpfr gmp mpc ninja cmake llvm22 python3
+          pkg install -y ninja cmake llvm22 python3
 
     # Use MinSizeRel to reduce the size of the build.
     # Notice that CMP0141=NEW and MSVC_DEBUG_INFORMATION_FORMAT=Embedded are required
@@ -43,8 +43,6 @@ jobs:
         -DCMAKE_C_COMPILER=clang22
         -DCMAKE_BUILD_TYPE=RelWithDebInfo
         -DLLVM_ENABLE_RUNTIMES=libc
-        -DLLVM_LIBC_MPFR_INSTALL_PATH=/usr/local
-        -DLIBC_MPC_INSTALL_PATH=/usr/local
         -G Ninja
         -S runtimes
 

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the FreeBSD VM CI workflow for LLVM-libc to reduce overall execution time by eliminating reliance on MPFR/GMP/MPC-based math testing infrastructure in that job.

Changes:

  • Stop installing mpfr, gmp, and mpc in the FreeBSD VM setup step.
  • Remove CMake cache entries that point libc’s MPFR/MPC detection to /usr/local.

Comment thread .github/workflows/libc-freebsd-vm-tests.yml
@SchrodingerZhu SchrodingerZhu changed the title [libc][freebsd] remove exhaustive math tests [libc][freebsd] make CI build-only May 22, 2026
@SchrodingerZhu SchrodingerZhu requested a review from lntue May 22, 2026 01:38
Copy link
Copy Markdown
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we going from full tests to build only?

What's the runtime like if we just disable the exhaustive math tests?

@lntue
Copy link
Copy Markdown
Contributor

lntue commented May 22, 2026

Why are we going from full tests to build only?

What's the runtime like if we just disable the exhaustive math tests?

I agree, let just disable the MPFR math tests first to see how much time it takes for the rest of them.

@SchrodingerZhu
Copy link
Copy Markdown
Contributor Author

Pushed. Let's check the runtime first.

@SchrodingerZhu SchrodingerZhu changed the title [libc][freebsd] make CI build-only [libc][freebsd] skip exhaustive math tests in FreeBSD CI May 22, 2026
@SchrodingerZhu
Copy link
Copy Markdown
Contributor Author

Discussed with @lntue, 26mins testing seems acceptable for now.

@SchrodingerZhu SchrodingerZhu merged commit 0e9af25 into llvm:main May 22, 2026
15 checks passed
@SchrodingerZhu SchrodingerZhu deleted the libc/freebsd-remove-expensive-tests branch May 22, 2026 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants