Skip to content

Fix : Add timeout parameters to all HTTP requests #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justynigam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix : Add timeout parameters to all HTTP requests #686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvmbisect/llvmlab/gcs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def fetch_builds(project):

def get_compiler(url, filename):
"""Get the compiler at the url, and save to filename."""
r = HTTP_CLIENT.get(url)
r = HTTP_CLIENT.get(url, timeout=300) # 5 minutes for large downloads
r.raise_for_status()
with open(filename, 'wb') as fd:
for chunk in r.iter_content(CHUNK_SIZE):
Expand Down
1 change: 1 addition & 0 deletions premerge/ops-container/process_llvm_commits.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ def query_github_graphql_api(
"Authorization": f"bearer {github_token}",
},
json={"query": query},
timeout=30,
)

# Exit if API call fails
Expand Down
2 changes: 1 addition & 1 deletion zorg/jenkins/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,7 @@ def http_download(url, dest):
try:
print("GETting", url, "to", dest, "...")
session = requests.Session()
r = session.get(url)
r = session.get(url, timeout=60)
r.raise_for_status()
# Open our local file for writing
with open(dest, "wb") as local_file:
Expand Down
4 changes: 2 additions & 2 deletions zorg/jenkins/jobs/util/submit-debuginfo-statistics-to-lnt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@

pprint.pprint(to_send)
try:
requests.post("http://104.154.54.203/db_default/v4/nts/submitRun", data=to_send).raise_for_status()
requests.post("http://104.154.54.203/db_default/v4/nts/submitRun", data=to_send, timeout=30).raise_for_status()
except:
time.sleep(10)
print("Sleeping because of error.")
requests.post("http://104.154.54.203/db_default/v4/nts/submitRun", data=to_send).raise_for_status()
requests.post("http://104.154.54.203/db_default/v4/nts/submitRun", data=to_send, timeout=30).raise_for_status()
4 changes: 2 additions & 2 deletions zorg/jenkins/jobs/util/submit-lldb-statistics-to-lnt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@

pprint.pprint(to_send)
try:
requests.post("http://104.154.54.203/db_default/v4/nts/submitRun", data=to_send).raise_for_status()
requests.post("http://104.154.54.203/db_default/v4/nts/submitRun", data=to_send, timeout=30).raise_for_status()
except:
time.sleep(10)
print("Sleeping because of error.")
requests.post("http://104.154.54.203/db_default/v4/nts/submitRun", data=to_send).raise_for_status()
requests.post("http://104.154.54.203/db_default/v4/nts/submitRun", data=to_send, timeout=30).raise_for_status()