[CI] Filter explanations by test file at DB query time #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.7
boomanaiden154
added a commit
to boomanaiden154/llvm-zorg
that referenced
this pull request
Dec 27, 2025
Previously when trying to explain failures for either flaky tests or tests failing at head, we would not filter by test file from the database. This would result in a lot of results then being filtered by message, which does contain the test name. This is mostly a performance optimization as the test message in most cases will contain the name, but could still be a correctness issue if two tests with different names failed with the same message. Pull Request: llvm#689
boomanaiden154
added a commit
to boomanaiden154/llvm-zorg
that referenced
this pull request
Dec 27, 2025
Previously when trying to explain failures for either flaky tests or tests failing at head, we would not filter by test file from the database. This would result in a lot of results then being filtered by message, which does contain the test name. This is mostly a performance optimization as the test message in most cases will contain the name, but could still be a correctness issue if two tests with different names failed with the same message. Pull Request: llvm#689
dwblaikie
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when trying to explain failures for either flaky tests or
tests failing at head, we would not filter by test file from the
database. This would result in a lot of results then being filtered by
message, which does contain the test name. This is mostly a performance
optimization as the test message in most cases will contain the name,
but could still be a correctness issue if two tests with different names
failed with the same message.