Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] clarify headers in development.md #4048

Merged

Conversation

bjacobgordon
Copy link
Contributor

No description provided.

@bjacobgordon
Copy link
Contributor Author

@marbre @ScottTodd Wanting to make it easier for you to accept the changes you do like, so I've taken the first two tiny commits from #3932 and put them into their own PR as is! Hopefully that'll move along the overall doc refresh and prevent this stack of PRs from going stale.

How's this one look?

@ScottTodd ScottTodd self-requested a review February 25, 2025 14:52
Copy link
Member

@marbre marbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and definitely is an improvement of the existing documentation. Thanks!

@ScottTodd
Copy link
Member

Looks good! Want one of us to merge for you?

@bjacobgordon bjacobgordon force-pushed the docs-clarifies-headers-in-development-md branch from 4103746 to 33298a7 Compare February 25, 2025 16:57
@bjacobgordon
Copy link
Contributor Author

bjacobgordon commented Feb 25, 2025

@ScottTodd Yes, please! GitHub isn't giving me the option for some reason. Just rebased onto main for ya. 👍

@marbre marbre enabled auto-merge (squash) February 25, 2025 17:01
@marbre
Copy link
Member

marbre commented Feb 25, 2025

@ScottTodd Yes, please! GitHub isn't giving me the option for some reason. Just rebased onto main for ya. 👍

It is probably simply that you don't have write access to the repo. I enabled squash auto-merge for the PR.

@marbre marbre merged commit 66dc639 into llvm:main Feb 25, 2025
3 checks passed
@bjacobgordon bjacobgordon deleted the docs-clarifies-headers-in-development-md branch February 25, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants