Integrate LLVM at 6d847b1aada50d59c3e29f2e7eff779c0ee8182c #4073
+333
−235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 1: [TOSA] Update tosa.transpose's perms as attributes * Update tosa.transpose's `perms` to attributes according to TOSA 1.0 * Update LIT tests Signed-off-by: Justin Ngo <[email protected]> Change-Id: Ica81298db8acaf15e1e29e41cffa1f70e726ad5c Commit 2: [TOSA] Rename ReduceProd to ReduceProduct Update ReduceProd name to ReduceProduct in align with TOSA 1.0 spec Signed-off-by: Justin Ngo <[email protected]> Change-Id: Ia285ac013ea8b57021f72a2c3b46e3ac33c07750 Commit 3: [TOSA] Change PadOp's pad_const to rank 1 Require PadOp's pad_const to be rank 1 in align with TOSA 1.0 spec Signed-off-by: Justin Ngo <[email protected]> Change-Id: Ic51d9ac2544a6c12234afc5208f08efced9dd124 Commit 4: [TOSA] Generate correct parameters for conv ops Bug fix: According to TOSA spec (https://www.mlplatform.org/tosa/tosa_spec.html#_conv2d), full height and width values must be divisible by stride values. This commit adds checks for that divisibility and modifies pad values and/or slices input to generate TOSA-compliant parameters for convolution ops. Signed-off-by: Justin Ngo <[email protected]> Change-Id: I6341450c324ec5d58907acc3c711614f24343a73 Commit 5: [TOSA] Update LIT tests and e2e results Signed-off-by: Justin Ngo <[email protected]>
vivekkhandelwal1
requested review from
sjarus,
AmosLewis,
zjgarvey and
jinchen62
sjarus
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update LLVM to llvm/llvm-project@6d847b1
TOSA Updates Summary:
1: [TOSA] Update tosa.transpose's perms as attributes
Update tosa.transpose's perms to attributes according to TOSA 1.0
Update LIT tests
2: [TOSA] Rename ReduceProd to ReduceProduct
Update ReduceProd name to ReduceProduct in align with TOSA 1.0 spec
3: [TOSA] Change PadOp's pad_const to rank 1
Require PadOp's pad_const to be rank 1 in align with TOSA 1.0 spec
4: [TOSA] Generate correct parameters for conv ops
Bug fix: According to TOSA spec
(https://www.mlplatform.org/tosa/tosa_spec.html#_conv2d), full height and width values must be divisible by stride values. This commit adds checks for that divisibility and modifies pad values and/or slices input to generate TOSA-compliant parameters for convolution ops.
5: [TOSA] Update LIT tests and e2e results
Signed-off-by: Vivek Khandelwal [email protected]
Co-authored-by: Justin Ngo [email protected]