Cache table structure on PDO object #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to ac6f81d for table exists checks. By remembering the table structure, we don't need to look it up each time we want to insert or update a row. Saves a little bit of time off mass-inserts/updates. Until we can improve `alterTable()`, the cached table structure is cleared whenever a change is made to the table. Added: - Method `setTableStructure()` to store copy of table schema on PDO instance - Method `queryTableStructure()` to prepare and run actual table schema retrieval Changed: - Method `tableStructure()` to delegate and remember lookup - Method `alterTable() to clear cached table structure
mcaskill
force-pushed
the
mcaskill-patch-table-structure
branch
from
00a6bd4 to
3561c6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to ac6f81d for table exists checks.
By remembering the table structure (for the duration of the request), we don't need to look it up each time we want to insert or update a row. Saves a little bit of time off mass-inserts/updates.
Note: Until
alterTable()routines can be improved, the cached table structure is cleared whenever a change is made to the table schema.Added:
setTableStructure()to store copy of table schema on PDO instancequeryTableStructure()to prepare and run actual table schema retrievalChanged:
tableStructure()to delegate and remember lookup