Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): Don't build ingest-ARM until that's supported #1418

Merged
merged 3 commits into from
Mar 21, 2024
Merged

fix(ingest): Don't build ingest-ARM until that's supported #1418

merged 3 commits into from
Mar 21, 2024

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented Mar 21, 2024 •
edited
Loading

Summary

  • fix(ingest): Don't build ingest-ARM until that's supported, then main deployment should work again
  • chore(e2e): disable ingest by default in deploy.py. Save resources, as ingest produces lots of CPU load. We already disable preprocessing
  • Don't trigger E2E runs when preprocessing code changes, as preprocessing isn't run in e2e deployment

@corneliusroemer corneliusroemer marked this pull request as ready for review March 21, 2024 13:59
@corneliusroemer corneliusroemer enabled auto-merge (squash) March 21, 2024 14:03
@corneliusroemer corneliusroemer merged commit 8e0d5f4 into main Mar 21, 2024
13 checks passed
@corneliusroemer corneliusroemer deleted the fix-ingest branch March 21, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaoran-chen chaoran-chen chaoran-chen approved these changes

@theosanderson theosanderson Awaiting requested review from theosanderson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corneliusroemer @chaoran-chen