Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): submit nav link always goes to submission portal #1419

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

bh-ethz
Copy link
Contributor

@bh-ethz bh-ethz commented Mar 21, 2024

resolves #1295, resolves #1124

preview URL: http://submit-landing-page.loculus.org/

  • Clicking Submit in the nav bar will always go to the submission portal.
  • Show buttons on the portal page instead of small links.

Screenshot 2024-03-21 at 15 20 49

@bh-ethz bh-ethz added the preview Triggers a deployment to argocd label Mar 21, 2024
@bh-ethz bh-ethz self-assigned this Mar 21, 2024
@bh-ethz bh-ethz marked this pull request as ready for review March 21, 2024 14:32
@bh-ethz bh-ethz requested a review from corneliusroemer March 21, 2024 14:32
@corneliusroemer
Copy link
Contributor

Looks great, I like the cards instead of text links!

Should we center the cards in the middle third of the screen. It's not clear to me why it should be on the left hand side. The submit dialogue is centered:

image

This is where the cards are on a big screen:
image

@bh-ethz
Copy link
Contributor Author

bh-ethz commented Mar 21, 2024

Should we center the cards

Yes probably. Users arrive here from the organism selection page which also isn't centered, so I wasn't sure what convention we're going for. Perhaps we center both pages?

@corneliusroemer
Copy link
Contributor

corneliusroemer commented Mar 21, 2024

Yes probably. Users arrive here from the organism selection page which also isn't centered, so I wasn't sure what convention we're going for. Perhaps we center both pages?

Yes I'm pretty sure we should center everything - that's what we're doing for pages that have undergone a bit more UI development. I think in the beginning we just went for the default/lazy option and didn't care much about how it looks.

If you rebase onto main, the E2E might work again (or at least faster)

@bh-ethz bh-ethz force-pushed the submit-landing-page branch from 11b7af2 to 19ea497 Compare March 21, 2024 15:50
Copy link
Member

@chaoran-chen chaoran-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Cornelius' comments, otherwise it looks good!

@theosanderson
Copy link
Member

Nice - some icons might spruce it up even further: https://icon-sets.iconify.design/

@bh-ethz bh-ethz force-pushed the submit-landing-page branch from ebe9b0d to 589471e Compare March 22, 2024 11:34
@bh-ethz
Copy link
Contributor Author

bh-ethz commented Mar 22, 2024

Nice - some icons might spruce it up even further: https://icon-sets.iconify.design/

Yes! I had a look but decided to get back to this another time (feel free to add them if you feel inspired to do it).

@bh-ethz bh-ethz merged commit d88baa0 into main Mar 22, 2024
13 checks passed
@bh-ethz bh-ethz deleted the submit-landing-page branch March 22, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top nav "submit" seems to direct to different pages, depending on current page Submit landing page
4 participants