-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(website): submit nav link always goes to submission portal #1419
Conversation
Yes probably. Users arrive here from the organism selection page which also isn't centered, so I wasn't sure what convention we're going for. Perhaps we center both pages? |
Yes I'm pretty sure we should center everything - that's what we're doing for pages that have undergone a bit more UI development. I think in the beginning we just went for the default/lazy option and didn't care much about how it looks. If you rebase onto main, the E2E might work again (or at least faster) |
11b7af2
to
19ea497
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Cornelius' comments, otherwise it looks good!
Nice - some icons might spruce it up even further: https://icon-sets.iconify.design/ |
19ea497
to
ebe9b0d
Compare
ebe9b0d
to
589471e
Compare
Yes! I had a look but decided to get back to this another time (feel free to add them if you feel inspired to do it). |
resolves #1295, resolves #1124
preview URL: http://submit-landing-page.loculus.org/