fix(ingest): Delay test data upload by 120 seconds so it only happens after new database up #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… after new database up
corneliusroemer
requested review from
theosanderson,
chaoran-chen,
emmahodcroft and
rneher
chaoran-chen
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Slight temporary hack to make sure we always end up submitting data to the new database of the new deployment, not the old one that's still hanging around because ingest is up so fast.
I'll make this more robust later, but for now this ensures we always have data for previews to make everyone's lives easier.
Solves this problem (mostly):
Though we still want to ensure LAPIS is cleared after new deployment, see #1438