fix(backend): fix the inability to access revision form due to checking status #3227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theosanderson
changed the title
theosanderson
changed the title
|
ok, it had a test maybe it wasn't accidental :) |
|
Nice was about to make the same change. Line must have come back at manual resolution of merge conflicts in #3125 |
|
Ah good point - it is indeed the original code rather than being written anew |
|
It was added back here as "Fixed all tests" - doesn't seem to have been a merge conflict, or at least it's not annotated as such: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://fix-unable-to-edit.loculus.org/
resolves #3224
This line was added in #3125 accidentally when resolving merge conflicts
This is another reason to potentially rename this endpoint to avoid confusion as Chaoran suggested once