Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): check formatting of docs in ci and do initial formatting #3734

Merged
merged 7 commits into from
Feb 26, 2025

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented Feb 24, 2025

TODO: still fails due to some ignore file thing

Closes #2419

  • It works, it fails when it's not formatted:
image
  • The biggest diff here is that we need to format to pass things

@corneliusroemer corneliusroemer changed the title chore(ci): check formatting of docs in ci chore(docs): check formatting of docs in ci and do initial formatting Feb 24, 2025
@corneliusroemer corneliusroemer marked this pull request as draft February 24, 2025 10:11
@fhennig
Copy link
Contributor

fhennig commented Feb 25, 2025

I found this indent with 3 spaces a bit odd:

4. Send a POST request:
   - The API path to use is: `<Backend URL>/<organism>/submit`
   - Add your group ID to the query parameters: `?groupId=<group id>`

But I checked and it looks fine:

image

Probably it was done like that so it lines up with the text after "4. "

@fhennig
Copy link
Contributor

fhennig commented Feb 25, 2025

@corneliusroemer you mentioned you have a lot of stuff to do, so I took the liberty to pick up your work here.

I have added the .gitignore file to the prettier check-format command to fix the issue you had initially.

I have also changed the formatting for md and mdx files to 2 space indent, as it's what we always use for YAML, so the YAML examples look right.

I hope that was fine!

@corneliusroemer
Copy link
Contributor Author

Thanks @fhennig thanks for picking it up! I just have one comment re making format and check-format consistent. Feel free to approve (and merge if you like).

@corneliusroemer corneliusroemer marked this pull request as ready for review February 25, 2025 12:29
Co-authored-by: Cornelius Roemer <[email protected]>
@fhennig
Copy link
Contributor

fhennig commented Feb 25, 2025

yes good point about the formatting!

Since Chaoran created the issue initially, I'll let him also have a look at do the final approval.

@chaoran-chen

Copy link
Member

@chaoran-chen chaoran-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, thank you!

@fhennig fhennig merged commit 38458a8 into main Feb 26, 2025
17 checks passed
@fhennig fhennig deleted the docs-format-ci branch February 26, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check code formatting of the Loculus docs in CI
3 participants