-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): check formatting of docs in ci and do initial formatting #3734
Conversation
b5a33fc
to
8e2a97c
Compare
@corneliusroemer you mentioned you have a lot of stuff to do, so I took the liberty to pick up your work here. I have added the .gitignore file to the prettier check-format command to fix the issue you had initially. I have also changed the formatting for md and mdx files to 2 space indent, as it's what we always use for YAML, so the YAML examples look right. I hope that was fine! |
Thanks @fhennig thanks for picking it up! I just have one comment re making format and check-format consistent. Feel free to approve (and merge if you like). |
Co-authored-by: Cornelius Roemer <[email protected]>
yes good point about the formatting! Since Chaoran created the issue initially, I'll let him also have a look at do the final approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, thank you!
TODO: still fails due to some ignore file thing
Closes #2419