Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(grammar): Change error message to have correct grammar #3766

Merged
merged 1 commit into from
Feb 26, 2025
Merged

chore(grammar): Change error message to have correct grammar #3766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../src/main/kotlin/org/loculus/backend/service/submission/AccessionPreconditionValidator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ class AccessionPreconditionValidator(

if (sequenceEntriesNotInStatuses.isNotEmpty()) {
throw UnprocessableEntityException(
"Accession versions are in not in one of the states $statuses: " +
"Accession versions are not in one of the states $statuses: " +
sequenceEntriesNotInStatuses.joinToString(", "),
)
}
Expand Down
2 changes: 1 addition & 1 deletion ...st/kotlin/org/loculus/backend/controller/seqsetcitations/SeqSetValidationEndpointsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ class SeqSetValidationEndpointsTest(
jsonPath(
"\$.detail",
containsString(
"Accession versions are in not in one of the states [APPROVED_FOR_RELEASE]",
"Accession versions are not in one of the states [APPROVED_FOR_RELEASE]",
),
),
)
Expand Down
2 changes: 1 addition & 1 deletion ...test/kotlin/org/loculus/backend/controller/submission/ApproveProcessedDataEndpointTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ class ApproveProcessedDataEndpointTest(
jsonPath(
"$.detail",
containsString(
"Accession versions are in not in one of the states " +
"Accession versions are not in one of the states " +
"[$PROCESSED]: " +
"${accessionVersionNotInCorrectState.first().displayAccessionVersion()} - $IN_PROCESSING",
),
Expand Down
2 changes: 1 addition & 1 deletion .../src/test/kotlin/org/loculus/backend/controller/submission/DeleteSequencesEndpointTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ class DeleteSequencesEndpointTest(
)

val listOfAllowedStatuses = "[${Status.RECEIVED}, ${Status.PROCESSED}]"
val errorString = "Accession versions are in not in one of the states $listOfAllowedStatuses: " +
val errorString = "Accession versions are not in one of the states $listOfAllowedStatuses: " +
accessionVersionsToDelete.sortedWith(AccessionVersionComparator).joinToString(", ") {
"${it.accession}.${it.version} - ${it.status}"
}
Expand Down
2 changes: 1 addition & 1 deletion backend/src/test/kotlin/org/loculus/backend/controller/submission/ReviseEndpointTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ class ReviseEndpointTest(
jsonPath(
"\$.detail",
containsString(
"Accession versions are in not in one of the states [APPROVED_FOR_RELEASE]: " +
"Accession versions are not in one of the states [APPROVED_FOR_RELEASE]: " +
"${accessions.first()}.1 - PROCESSED,",
),
),
Expand Down
2 changes: 1 addition & 1 deletion backend/src/test/kotlin/org/loculus/backend/controller/submission/RevokeEndpointTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ class RevokeEndpointTest(
jsonPath(
"\$.detail",
containsString(
"Accession versions are in not in one of the states [${Status.APPROVED_FOR_RELEASE}]: " +
"Accession versions are not in one of the states [${Status.APPROVED_FOR_RELEASE}]: " +
"${accessions.first()}.1 - ${Status.PROCESSED},",
),
),
Expand Down
2 changes: 1 addition & 1 deletion ...st/kotlin/org/loculus/backend/controller/submission/SubmitExternalMetadataEndpointTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ class SubmitExternalMetadataEndpointTest(
.value(
containsString(
(
"Accession versions are in not in one of the states " +
"Accession versions are not in one of the states " +
"[APPROVED_FOR_RELEASE]: $accession"
),
),
Expand Down
Loading