Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move preview/ppx specific Helm Chart settings out of the default values #3776

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Feb 28, 2025

resolves #3637

preview URL: https://untangle-values.loculus.org

Summary

  • move email SMTP settings out.
  • remove ORCID setting.

Is this breaking for PPX?

manual testing

I created an account on the preview, and still got the mail.

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by appropriate, automated tests. (I don't think a test is needed)
  • Any manual testing that has been done is documented (i.e. what exactly was tested?)

@fhennig fhennig added the preview Triggers a deployment to argocd label Feb 28, 2025
@fhennig fhennig self-assigned this Feb 28, 2025
@fhennig fhennig changed the title move preview/ppx specific Helm Chart settings out of the default values chore: move preview/ppx specific Helm Chart settings out of the default values Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loculus specific SMTP and ORCiD settings are in the Helm Chart by default
1 participant