672 add functionality to mock up #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiasKampmann
changed the base branch from
main
to
671-adapt-endpoints-that-validate-submitter
TobiasKampmann
force-pushed
the
671-adapt-endpoints-that-validate-submitter
branch
2 times, most recently
from
0bce757 to
4195801
Compare
TobiasKampmann
force-pushed
the
672-add-functionality-to-mock-up
branch
from
f7084ff to
af49263
Compare
TobiasKampmann
force-pushed
the
671-adapt-endpoints-that-validate-submitter
branch
from
4195801 to
57ccadc
Compare
TobiasKampmann
force-pushed
the
672-add-functionality-to-mock-up
branch
from
af49263 to
64bca20
Compare
TobiasKampmann
force-pushed
the
671-adapt-endpoints-that-validate-submitter
branch
from
57ccadc to
4f2b42c
Compare
TobiasKampmann
force-pushed
the
672-add-functionality-to-mock-up
branch
2 times, most recently
from
05b7127 to
7bd86c8
Compare
Base automatically changed from
671-adapt-endpoints-that-validate-submitter
to
main
December 22, 2023 10:44
TobiasKampmann
force-pushed
the
672-add-functionality-to-mock-up
branch
from
7bd86c8 to
b98e200
Compare
TobiasKampmann
force-pushed
the
672-add-functionality-to-mock-up
branch
from
b98e200 to
e46a468
Compare
TobiasKampmann
commented
Dec 22, 2023
TobiasKampmann
commented
Dec 22, 2023
TobiasKampmann
force-pushed
the
672-add-functionality-to-mock-up
branch
2 times, most recently
from
742db0d to
eff5b78
Compare
|
I think, we should not link to |
fengelniederhammer
requested changes
Dec 22, 2023
There was a problem hiding this comment.
Some things that I noticed:
- The "Group" in the navigation on the top left does not work -> remove it?
- When I try to submit data, it tells me "Not Found: Group testGroup does not exist.". I think we're missing an input field there, or will that be part of the next ticket? Also this should probably not return a 404, since the route exists. It just didn't find the group, which sounds more like 424 to me.
TobiasKampmann
force-pushed
the
672-add-functionality-to-mock-up
branch
2 times, most recently
from
c4c44e5 to
adee037
Compare
TobiasKampmann
force-pushed
the
672-add-functionality-to-mock-up
branch
from
adee037 to
0551ce4
Compare
fengelniederhammer
approved these changes
Jan 8, 2024
TobiasKampmann
force-pushed
the
672-add-functionality-to-mock-up
branch
2 times, most recently
from
5708bf0 to
1e42a45
Compare
TobiasKampmann
force-pushed
the
672-add-functionality-to-mock-up
branch
from
1e42a45 to
71f7d2d
Compare
… on GroupPage and Manager, adapt e2e * adapt endpoint to be more restful
TobiasKampmann
force-pushed
the
672-add-functionality-to-mock-up
branch
from
71f7d2d to
c9851df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.