Fix nearfield_imager and singlestationutil import
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converted to draft, "works on my machine", but it has a 100% success rate for killing Jupyter kenels on RS307 on import. Never thought a jupyter kernel could panic and create a coredump for an import, but you learn something new every day. |
|
Okay, whatever is happening on RS307 is independent of the lofarimaging version, it just crashes whether I use this MR reference, a tagged branch on my repo, or the current HEAD on master here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes missing variables that were removed as "unused" in #15, closes #16.
The latest versions of astropy have removed
get_moonas foreseen in #10, this moves the call over toget_bodyso that the module can still be used and closes #10.