-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SQLite parser for Android Native Downloads (downloads.db) file #4929
base: main
Are you sure you want to change the base?
Conversation
For Android Native Downloads Sqlite Plugin
For Sqlite Android Native Downloads Plugin
Thanks for the PR, I'm a bit preoccupied at the moment will try to take a look as soon as time permits |
@ChristopherGammaWau what is the origin of the test data file? |
For Android Native Downloads Sqlite Plugin
For Sqlite Android Native Downloads Plugin
Rebased PR |
@ChristopherGammaWau @barpeot can one of you PTAL at the linter warnings |
Fix lint error "line too long" in plugin test file.
This reverts commit cb5c1ea.
Hello Mr. Joachimmetz, Unless changes are done to the source, the file is obtained from the android 13 image found on this link: https://digitalcorpora.s3.amazonaws.com/corpora/mobile/android_13/android_13_data.tar.gz. Edit: After checking the original image, the "downloads.db" file used can be found under "data\data\com.android.providers.downloads\databases". The one commited to github has an entry modified with a different status code. But the entry used in the unit test is identical with the original file.
I will try to fix the lint warnings in the following days. I am sorry for the last 3 commits since i made a mistake in pushing too early. I will tag you in this pull request once i've made my changes. Thank you. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4929 +/- ##
==========================================
+ Coverage 85.05% 85.11% +0.06%
==========================================
Files 431 433 +2
Lines 38645 38852 +207
==========================================
+ Hits 32870 33070 +200
- Misses 5775 5782 +7 ☔ View full report in Codecov by Sentry. |
Thanks for the additional context, given the test file was edited I'll treat this as "derived work" then |
One line description of pull request
Add SQLite parser for Android Native Downloads (downloads.db) file
Description:
I add/edit several files:
Add import android_native_downloads to plaso/parsers/sqlite_plugins/init.py
Add a new parser plugin android_native_downloads.py to plaso/parsers/sqlite_plugins/
Add downloads.db file to plaso/test_data/
Add unit test android_native_downloads.py to plaso/tests/parsers/sqlite_plugins/
Modify android.yaml to support Android Native Downloads SQLite parser plugin (plaso/data/formatters/android.yaml)
Modify timeliner.yaml to support Android Native Downloads SQLite parser plugin (plaso/data/timeliner.yaml)
Notes:
All contributions to Plaso undergo code review.
This makes sure that the code has appropriate test coverage and conforms to the
Plaso style guide.
One of the maintainers will examine your code, and may request changes. Check off the items below in
order, and then a maintainer will review your code.
Checklist: